This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
[#139] Add a validation to enable/disable the save button of the Edit Profile view #143
Open
ednofedulo
wants to merge
6
commits into
anitab-org:develop
Choose a base branch
from
ednofedulo:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e3d14de
add validation to enable/disable save button on edit profile view bas…
ednofedulo dbe91e1
change the function that validates the name to be a computed property
ednofedulo dc18c40
Merge branch 'develop' into develop
yugantarjain 8e6e870
- add tests to canSave computed property
ednofedulo ee29a51
change the name of the test method that tests the disable state of th…
ednofedulo 78bb36b
Merge branch 'develop' into develop
yugantarjain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,10 @@ struct ProfileEditor: View { | |
@State var editProfileData = ProfileViewModel().getEditProfileData() | ||
@ObservedObject var profileViewModel = ProfileViewModel() | ||
|
||
var canSave:Bool { | ||
return (self.editProfileData.name ?? "").isEmpty == false | ||
} | ||
|
||
// make api call to update profile | ||
func updateProfile() { | ||
self.profileService.updateProfile(updateProfileData: self.editProfileData) { response in | ||
|
@@ -79,7 +83,7 @@ struct ProfileEditor: View { | |
self.profileViewModel.inActivity = true | ||
// make network call to update profile | ||
self.updateProfile() | ||
}) | ||
}.disabled(self.canSave == false)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we can do something like .disabled(editProfileData.name.isEmpty) |
||
.alert(isPresented: $profileViewModel.showAlert) { | ||
Alert.init( | ||
title: Text(profileViewModel.alertTitle), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change name to enableSaveButton/disableSaveButton. More descriptive.