Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Xcode 12 UI fixes #151

Merged
merged 6 commits into from
Nov 11, 2020
Merged

Conversation

aaryankotharii
Copy link
Contributor

Description

Minor changes is code to fix UI bugs caused by SwiftUI 2.0 and to make sure UI is same as intended.

Fixes #141

Screenshots

Login SignUp Home
Login SignUp Home
Request Detail Profile Profile Editor
RequestDetail Profile Editor
Members Search Member Detail Send Request
Search MemberDetail SendRequest
Settings About Change Password
Settings About ChangePassword

Type of Change:

Delete irrelevant options.

  • Code
  • User Interface

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)

How Has This Been Tested?

Tested with Xcode simulator. ( iOS 14 )

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@aaryankotharii
Copy link
Contributor Author

@yugantarjain, I cant test UI for relationView as I am unable to create a new account. I am getting status code 500 in signup response .
Here is the requestBody:

SignUpUploadData(name: "AARYAN K", username: "Aaryank", password: "12345678", email: "aaryan.kothari2019@vitstudent.ac.in", tncChecked: true, needMentoring: true, availableToMentor: false)

Copy link
Contributor

@yugantarjain yugantarjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks!

Copy link
Contributor

@ApheleiaS ApheleiaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @aaryankotharii!

@yugantarjain yugantarjain merged commit 85be5d9 into anitab-org:develop Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update app for Xcode 12 (UI fixes)
3 participants