This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
#1050 UI:Change behaviour of address field in signup admin page #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@rkpattnaik780 Please check the PR now. |
|
Hello @psingh587 , I can see there are still a few indentation problems. I can comment all the lines with distorted indentation if that will help. And do squash your commits and follow these guidelines for commit message. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Sign Up Admin, I have made the city and state input disabled until the country is filled first. The city is disabled until the state is filled first.
Fixes #1050
Type of Change:
How Has This Been Tested?
Checked in my local server. Works well according to me. I have handled all the scenarios.
Checklist: