Add checks for extra field in model create

[Monal5031]

Description

Until now only mandatory fields were being saved but we should add checks for other fields too, at least in 1 test. Since these are non-mandatory fields and we'll be shifting to using dicts instead of lists I've used a workaround for now (using length compare) while creating the event. In future we'll need to modify it

Fixes #752

Type of Change:

Delete irrelevant options.

• Code
• Quality Assurance

Code/Quality Assurance Only

• Bug fix (non-breaking change which fixes an issue)
• This change requires a documentation update (software upgrade on readme file)
• New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

python manage.py test event.tests.test_model -v 2

Checklist:

Delete irrelevant options.

• My PR follows the style guidelines of this project
• I have performed a self-review of my own code or materials
• I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged

Code/Quality Assurance Only

• My changes generate no new warnings
• My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been published in downstream modules

[ayushgarg1804]

Instead of modifying attributes afterwards won't it be a better practice to pass it during Event init itself.

[Monal5031]

This is the hacky way you suggested in meeting so that only 1 test is changed otherwise we'll have to modify like every test done till now. Also this will anyhow get changed when we implement dictionaries.

[naman1901]

Why are we not moving to dicts rightaway?

[Monal5031]

Because moving to dictionaries has a lot of dependency and will need existing tests to be completed first so we can tackle all problem at once.

[ayushgarg1804]

You can have a check of len(event) by if else inside which you call the Event constructor as done in b4afaff

[Monal5031]

Okay 👍

[anjali-dhanuka]

@Monal5031 As per your comment on my PR, I think you must include these fields in error message function. create locators etc.

[Monal5031]

Yup I am, this is a stretch goal for this week. Thanks for reminding again :)
I also have to include fields of other apps too rn its just for event.

Accidental

[Monal5031]

@naman1901 @ayushgarg1804 @MehaKaushik @pavankm The checks for fields in shift app (model checks) will be added in #726 and for administrator in #780 . For admin and volunteer the checks had previously been done in #724 .
Please review this PR.

[naman1901]

Looks good!

[Monal5031]

ping @naman1901 @MehaKaushik @ayushgarg1804 Please review.

[ayushgarg1804]

@Monal5031 there's a test which is failing

[Monal5031]

Same thing as in the documentation PR. @ayushgarg1804 will restart it in a bit.