Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export parseAs function #5

Closed
wants to merge 1 commit into from
Closed

Export parseAs function #5

wants to merge 1 commit into from

Conversation

Claudemirovsky
Copy link

I tested it with the Vizer.tv(pt-BR) extension and it worked as expected.
Related with #3

@Claudemirovsky
Copy link
Author

Update: This may be broken if the app merges upstream and applies this commit, as it changes the body of the parseAs function and as a inline function, the usual "hey bro thats a stub" implementation doesnt work and requires a update.
Should i update this PR now to reflect this commit or only after the main app merges upstream changes?

@Claudemirovsky
Copy link
Author

Closing the PR, as this newer commit forces the usage of context sheninagans, and i don't think that enabling context-receivers and importing kotlinx-serialization as compileOnly would be worth it for a single extension function.

@Claudemirovsky Claudemirovsky deleted the export-parseas branch June 2, 2023 02:27
@Claudemirovsky Claudemirovsky mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Claudemirovsky