Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templated benchmarks improvements #2

Merged

Conversation

bpkroth
Copy link

@bpkroth bpkroth commented Sep 25, 2023

  • enable testing locally via docker build-run script
  • enable random seed from config
  • enable sqlite support
  • use sqlite support to implement unit tests
  • use unit tests to walk through debugger to find error (csv parsing)
  • left some TODO comments about adding support for NULL processing
    • I handled one of these, but there's some lingering work that should probably be taken up separately for improving this to be able to pass NULLable values as a parameter.
      For instance, c VARCHAR(255) NULL type columns can't receive a NULL value atm via something like <value /> since the values are passed to the constructors as a comma separated string list, which gets parsed back out as an empty string.

@bpkroth bpkroth marked this pull request as ready for review September 25, 2023 21:54
@bpkroth bpkroth changed the title WIP: Templated benchmarks improvements Templated benchmarks improvements Sep 26, 2023
@anjagruenheid anjagruenheid merged commit f396bdc into anjagruenheid:templated_benchmarks Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants