Skip to content

Commit

Permalink
ghci: install mingw 11.2.0 to workaround go linking failure
Browse files Browse the repository at this point in the history
recently windows runners in github CI was changed to pre-install
mingw 12.2.0 which broke building crc with the following error:

```
GOARCH=amd64 GOOS=windows go build -tags "containers_image_openpgp" -ldflags="-X github.com/crc-org/crc/v2/pkg/crc/version.crcVersion=2.26.0 -X github.com/crc-org/crc/v2/pkg/crc/version.ocpVersion=4.13.9 -X github.com/crc-org/crc/v2/pkg/crc/version.okdVersion=4.13.0-0.okd-2023-06-04-080300 -X github.com/crc-org/crc/v2/pkg/crc/version.podmanVersion=4.4.4 -X github.com/crc-org/crc/v2/pkg/crc/version.microshiftVersion=4.13.9 -X github.com/crc-org/crc/v2/pkg/crc/version.commitSha=46e313 " -o out/windows-amd64/crc.exe  ./cmd/crc
C:\hostedtoolcache\windows\go\1.19.13\x64\pkg\tool\windows_amd64\link.exe: running gcc failed: exit status 1
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-867149281\000007.o: in function `_cgo_preinit_init':
\\_\_\runtime\cgo/gcc_libinit_windows.c:40: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-867149281\000007.o: in function `x_cgo_notify_runtime_init_done':
\\_\_\runtime\cgo/gcc_libinit_windows.c:105: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-867149281\000007.o: in function `_cgo_beginthread':
\\_\_\runtime\cgo/gcc_libinit_windows.c:149: undefined reference to `__imp___iob_func'
C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\go-link-867149281\000008.o: in function `x_cgo_thread_start':
\\_\_\runtime\cgo/gcc_util.c:18: undefined reference to `__imp___iob_func'
collect2.exe: error: ld returned 1 exit status

mingw32-make: *** [Makefile:105: out/windows-amd64/crc.exe] Error 1
Error: Process completed with exit code 1.
```
this should be fixed in golang 1.20 as per the issue: golang/go#57455
  • Loading branch information
anjannath committed Sep 26, 2023
1 parent 22d9ec4 commit 77398df
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/choco-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
go:
- 1.19
steps:
- name: Downgrade mingw to 11.2.0
run: choco install mingw --version 11.2.0 --allow-downgrade
- name: Check out repository code
uses: actions/checkout@v3
- name: Set up Go
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/make-check-win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
go:
- 1.19
steps:
- name: Downgrade mingw to 11.2.0
run: choco install mingw --version 11.2.0 --allow-downgrade
- name: Check out repository code
uses: actions/checkout@v3
- name: Set up Go
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/windows-chocolatey.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
go:
- 1.19
steps:
- name: Downgrade mingw to 11.2.0
run: choco install mingw --version 11.2.0 --allow-downgrade
- name: Check out repository code
uses: actions/checkout@v3
- name: Set up Go
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/windows-installer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
go:
- 1.19
steps:
- name: Downgrade mingw to 11.2.0
run: choco install mingw --version 11.2.0 --allow-downgrade
- name: Check out repository code
uses: actions/checkout@v3
- name: Set up Go
Expand Down

0 comments on commit 77398df

Please sign in to comment.