Skip to content

Allow multiple databases to be created. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from

Conversation

damncabbage
Copy link

eg. via something like:

      - uses: ankane/setup-postgres@v1
        with:
          database: |
            testdb
            testdb2

Context

I have a singular test run that needs a couple of separate databases created (as in, the test suite uses two databases in its test run).

Unfortunately, running the action twice with different databases results in a failing createdb call, as the user already exists.

I first had a go at making it fail gracefully if the user already exists, but ran into problems, and then realised that it would probably be more efficient (given the setup that the action does) to just allow creating multiple databases at once.

@john-h-k
Copy link

john-h-k commented Mar 6, 2023

Is there any possibility of this getting merged @ankane ?

tagliala added a commit to ifad/chronomodel that referenced this pull request May 5, 2024
tagliala added a commit to ifad/chronomodel that referenced this pull request May 5, 2024
tagliala added a commit to ifad/chronomodel that referenced this pull request May 5, 2024
This commit introduces an improvement in our testing strategy to ensure
broader compatibility across various PostgreSQL versions.

The primary focus remains on the latest stable release of PostgreSQL,
acknowledging the significance of maintaining support for older versions
to accommodate the longevity of applications.

To facilitate this, tests have been added to verify the application's
functionality against PostgreSQL 12.

Since `setup-postgres` action does not allow to create multiple
databases, consider a refactoring if ankane/setup-postgres#9 will be
merged.
@tagliala
Copy link

tagliala commented May 5, 2024

tagliala added a commit to ifad/chronomodel that referenced this pull request May 5, 2024
This commit introduces an improvement in our testing strategy to ensure
broader compatibility across various PostgreSQL versions.

The primary focus remains on the latest stable release of PostgreSQL,
acknowledging the significance of maintaining support for older versions
to accommodate the longevity of applications.

To facilitate this, tests have been added to verify the application's
functionality against PostgreSQL 12.

Since `setup-postgres` action does not allow to create multiple
databases, consider a refactoring if ankane/setup-postgres#9 will be
merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants