Allow multiple databases to be created. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any possibility of this getting merged @ankane ? |
tagliala
added a commit
to ifad/chronomodel
that referenced
this pull request
May 5, 2024
Refactor when ankane/setup-postgres#9 will be merged
tagliala
added a commit
to ifad/chronomodel
that referenced
this pull request
May 5, 2024
Refactor when ankane/setup-postgres#9 will be merged
tagliala
added a commit
to ifad/chronomodel
that referenced
this pull request
May 5, 2024
This commit introduces an improvement in our testing strategy to ensure broader compatibility across various PostgreSQL versions. The primary focus remains on the latest stable release of PostgreSQL, acknowledging the significance of maintaining support for older versions to accommodate the longevity of applications. To facilitate this, tests have been added to verify the application's functionality against PostgreSQL 12. Since `setup-postgres` action does not allow to create multiple databases, consider a refactoring if ankane/setup-postgres#9 will be merged.
|
Hello, having something like this would help for our use case too: |
tagliala
added a commit
to ifad/chronomodel
that referenced
this pull request
May 5, 2024
This commit introduces an improvement in our testing strategy to ensure broader compatibility across various PostgreSQL versions. The primary focus remains on the latest stable release of PostgreSQL, acknowledging the significance of maintaining support for older versions to accommodate the longevity of applications. To facilitate this, tests have been added to verify the application's functionality against PostgreSQL 12. Since `setup-postgres` action does not allow to create multiple databases, consider a refactoring if ankane/setup-postgres#9 will be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg. via something like:
Context
I have a singular test run that needs a couple of separate databases created (as in, the test suite uses two databases in its test run).
Unfortunately, running the action twice with different databases results in a failing
createdbcall, as the user already exists.I first had a go at making it fail gracefully if the user already exists, but ran into problems, and then realised that it would probably be more efficient (given the setup that the action does) to just allow creating multiple databases at once.