Fix packages: closed-chain-ik + electron-rebuild #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been trying to follow the directions, but I'm getting a new error that I'm working on solving: |
The only difference is that I edit the npm run i to have npm install --arch=x64, I am using an M1 macbook pro |
|
@Maxw3llGM Are you trying with a newer serialport version than the one
defined in package.json ?
…On Wed, Aug 23, 2023 at 17:13 Maxw3llGM ***@***.***> wrote:
I've been trying to follow the directions, but I'm getting a new error
that I'm working on solving:
App threw an error during load
Error: ***@***.***/bindings/build/Release/bindings.node, 0x0001): tried: ***@***.***/bindings/build/Release/bindings.node' (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64')), ***@***.***/bindings/build/Release/bindings.node' (no such file), ***@***.***/bindings/build/Release/bindings.node' (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64'))
at process.func (electron/js2c/asar.js:138:31)
at process.func [as dlopen] (electron/js2c/asar.js:138:31)
at Object.Module._extensions..node (internal/modules/cjs/loader.js:828:18)
at Object.func (electron/js2c/asar.js:138:31)
at Object.func [as .node] (electron/js2c/asar.js:138:31)
at Module.load (internal/modules/cjs/loader.js:645:32)
at Function.Module._load (internal/modules/cjs/loader.js:560:12)
at Module.require (internal/modules/cjs/loader.js:685:19)
at require (internal/modules/cjs/helpers.js:16:16)
at bindings (/Users/miu/Feelix_Proj/f_test/Feelix2.0/node_modules/bindings/bindings.js:112:48)
The only difference is that I edit the npm run i to have npm install
--arch=x64,
But even without the flag I am getting issues
I am using an M1 macbook pro
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADLGSE5FMZGC4ESRLVMZIDXWZW73ANCNFSM6AAAAAA333NXVY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@Maxw3llGM Are you getting the same issues without |
|
@Maxw3llGM Following your comment #1 (comment) I think you need to "add the most recent version of serialport in the package (10.4.0) as it add support for m1" and run |
I have been, my new issue is this: |
|
@Maxw3llGM Could you please post the whole trace? Otherwise the following repeated line may look like a warning:
|
|
This is the entire debug log when I end the process: |
Thanks @Maxw3llGM that helps! I notice from the log that you are using node@v14.19.1. From #3 (comment)
Could you please Note: I had to also |
|
@Maxw3llGM I have just added 2 more commits to this PR:
Feel free to pull! Feelix still launches on my side with these 2 updates. I have not yet tried serial com though. Note: after the electron update, when running so I had to fix this with: |
I will try with the 16.20.2 |
|
I still get: |
|
And I don't know how to get the debug unfortunately |
@Maxw3llGM What command triggers this stack trace? At what commit are you on the branch of this PR: the latest from yesterday or today? Maybe it's worth trying from the latest commit of today, on a clean branch, and deleting and regenerating |
…ponent.ts: setFilesInServices: merge this.file into service files
…mponent.html: add test for this.drawingService.file.activeEffect
|
@Maxw3llGM @ankevanoosterhout I have added 4 commits to this PR:
The last 3 fix renderer errors that appeared in the electron console. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ankevanoosterhout @Maxw3llGM This pull request simplifies the build instructions from @Maxw3llGM #1 (comment) into:
Changes
build_file_contentsopenflags https://github.com/nodejs/node-gyp/blob/v9.1.0/gyp/pylib/gyp/input.py instead of node-gyp ^5.1.0 from https://github.com/nodejs/node/blob/v14.19.1/deps/npm/package.json https://github.com/nodejs/node-gyp/blob/v5.1.0/gyp/pylib/gyp/input.py with'rU'flags,'U'deprecated with python 3.11)npm run iscript with rexreplace to fix closed-chain-ik worker syntax (to getconst worker = new Worker( new URL( './workerSolver.worker.js'/*, import.meta.url*/), { type: 'module' } );in https://github.com/gkjohnson/closed-chain-ik-js/blob/v0.0.4/src/worker/WorkerSolver.js#L30)