Allow converting extended deck from CrowdAnki format to source #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
approved these changes
Jan 23, 2025
|
Oh we need to update the Python version I think. |
Fix anki-geo#666 It would be convenient for a single recipe to exist, and (given that we're not actually saving the note model itself to file) it should be possible, from a theoretical flow-of-data point of view, but I don't think this is currently supported by BrainBrew — the exact name of the note model has to be provided. (It would also likely be non-trivial to do this correctly, robustly and flexibly (while also not dropping the option of using `save_to_file` in the general case), given that the only reason this could theoretically work is because both note models have the exact same fields.) Tested that the recipe works as expected by: 1. Generate the CrowdAnki files in `build/` with the source to Anki recipe. 2. Make a change in one of the `src/data/*.csv` files. (Note: this is necessary before *3* because otherwise BrainBrew correctly notices there are no changes, and doesn't actually re-sort the notes, which would make the later comparison messy.) 3. Run the Anki to source [extended] recipe. (This resorts the notes, but resetting the actual content to the state from before *2*.) 4. Make a change in `build/Ultimate Geography [EN] [Extended]/deck.json`. 5. Run the Anki to source [extended] recipe. 6. Compare the state between after *3* and after *5* and verify that your change was applied.
axelboc
force-pushed
the
anki_to_source_extended
branch
from
476fce1 to
f5f44f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #666
It would be convenient for a single recipe to exist, and (given that we're not actually saving the note model itself to file) it should be possible, from a theoretical flow-of-data point of view, but I don't think this is currently supported by BrainBrew — the exact name of the note model has to be provided. (It would also likely be non-trivial to do this correctly, robustly and flexibly (while also not dropping the option of using
save_to_filein the general case), given that the only reason this could theoretically work is because both note models have the exact same fields.)Tested that the recipe works as expected by:
Generate the CrowdAnki files in
build/with the source to Anki recipe.Make a change in one of the
src/data/*.csvfiles. (Note: this is necessary before 3 because otherwise BrainBrew correctly notices there are no changes, and doesn't actually re-sort the notes, which would make the later comparison messy.)Run the Anki to source [extended] recipe. (This resorts the notes, but resetting the actual content to the state from before 2.)
Make a change in
build/Ultimate Geography [EN] [Extended]/deck.json.Run the Anki to source [extended] recipe.
Compare the state between after 3 and after 5 and verify that your change was applied.