Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoteEditorIntentTest flaky test after the intent handling changes #15707

Closed
mikehardy opened this issue Feb 28, 2024 · 5 comments
Closed

NoteEditorIntentTest flaky test after the intent handling changes #15707

mikehardy opened this issue Feb 28, 2024 · 5 comments
Labels

Comments

@mikehardy
Copy link
Member

          We have a new flaky test after the intent handling changes, this popped up on another PR recently as well and caused merge queue ejection

com.ichi2.anki.NoteEditorIntentTest > launchActivityWithIntent[emulator-5554 - 11] FAILED 
	java.lang.ArrayIndexOutOfBoundsException: length=0; index=0
	at com.ichi2.anki.NoteEditorIntentTest.launchActivityWithIntent$lambda$0(NoteEditorIntentTest.kt:54)

Originally posted by @mikehardy in #15692 (comment)

  • step 1 mark flaky but not as resolving this issue
  • step 2 determine why this is flaking on emulator tests, may require instrumentation (that is, logging and such) in the test so it can run on the CI runners to get their timing (they are slower than your local machine) and then download the logcat to see what your logs say about why it failed
@david-allison
Copy link
Member

@criticalAY was this one which you added?

@criticalAY
Copy link
Contributor

Yes, but it worked fine, would look into it

@criticalAY
Copy link
Contributor

criticalAY commented Feb 28, 2024

I suspect the field is accessed before the editor is properly set i.e. the progress bar is still there and field is tried to set text on, as when the intent is passed it takes a second (emulator is slow so its visible)

Copy link
Contributor

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label May 28, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
@criticalAY criticalAY reopened this Jun 4, 2024
@criticalAY criticalAY removed the Stale label Jun 4, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Sep 3, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants