Show toast when importing without the app being started at least once

[lukstbit]

Purpose / Description

Fixes the linked issues by notifying the user through a toast(suggestions for the notice message of course welcome) and aborting the import that he must start the app at least once before he can import. At first I tried to be more precise in DeckPicker to try to remove the import dialog message from the handler and then show the toast, this didn't worked at all so I moved the check in IntentHandler.

Fixes

• Fixes [Bug] 2.17.1 IntroductionActivity cannot be cast to DeckPicker #15672

How Has This Been Tested?

Ran the tests(but hit some OutOfMemoryErrors) and manually installed debug apks(play and full) to first reproduce and then check the patch.

Learning (optional, can help others)

I dislike the handler system used for async dialogs.

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[github-actions]

Message to maintainers, this PR contains strings changes.

1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

• localization-administration
• download-localized-strings

[david-allison]

This feels verbose:

"Please open Anki and try again"? Or similar

[mikehardy]

code looks good to me as a way to handle the problem
I tried to take the strings suggestion to a prescriptive recommendation for an up/down vote so we can get this in quickly I hope

My approval is pending commit on those string proposals which I can do then squash-merge or can be done via rebase and pushed via lukstbit, either would work for me

If more discussion is needed because you all hate my suggestions (fair enough!) then I'll re-look after

[mikehardy]

Using the new string name from first comment, then I prefer a "what" message for users, followed by "prescriptive action". So I'd say:

Suggested change

	<string name="warning_start_app_before_import">Before importing app must be opened at least once for initialization</string>
	<string name="app_not_initialized">AnkiDroid is not initialized yet. Please open AnkiDroid once, then try again</string>

@david-allison would this work for you? If so and you're +1 on the rest of it, commit+squash these myself to get this in and queue up a 2.17.2 or obviously @lukstbit can (and also, obviously, if either of you disagree on my string-crafting let me know please!)

[lukstbit]

Went with your suggestion, David's suggestion might sound a bit negative to the user(like some unknown error happened).

[mikehardy]

Obviously works for me then since you just accepted all my changes 😆 - approving for avoidance of doubt, pending David saying yay/nay

[david-allison]

I feel it's a little verbose still, but two votes to one 😁

Let's get this in

[david-allison]

• Updated strings from Crowdin 2024/02/28 14:28 #15703

[mikehardy]

Note to myself more than anything - needs a string sync afterwards, and that strings sync needs a queued for cherry-pick label

[mikehardy]

We have a new flaky test after the intent handling changes, this popped up on another PR recently as well and caused merge queue ejection

com.ichi2.anki.NoteEditorIntentTest > launchActivityWithIntent[emulator-5554 - 11] FAILED 
	java.lang.ArrayIndexOutOfBoundsException: length=0; index=0
	at com.ichi2.anki.NoteEditorIntentTest.launchActivityWithIntent$lambda$0(NoteEditorIntentTest.kt:54)