feat: initial 'Remove account' implementation #16260

david-allison · 2024-04-23T18:59:11Z

Purpose / Description

Google require that we more prominently display 'Delete Account'

Fixes

Some of Invalid account/data deletion link listed in Google Play Store data safety form #16256

the path for requesting deletion is not prominently displayed (for example a little process diagram of "1) access this page 2) log in to the account 3) click delete account link" 4) confirm ?
- note that the destination URL of "remove-account" is not remembered for redirect after login if not authenticated which would be nice to have. So currently steps are "click remove-account link", "log in", "click account", "click remove account", "confirm", account is deleted...
⚠️ the name doesn't match - we are "AnkiDroid Flashcards" on Play Store listing but that is not listed on the page at all. This is difficult. We need to have that name on the Play Store, but the account is an "AnkiWeb" account based on the webpage. Is there a way to include some information on the deletion page that this account is used by all compatible Anki ecosystem apps including Anki Mobile, Anki Desktop, and AnkiDroid Flashcards?
Privacy Policy link

Approach

A 'remove account' button opens AnkiWeb
A user must log in to AnkiWeb if they did not already do so in 'Shared Decks'
- We perform an internal redirect back to the 'remove account' functionality
A user must enter their password
A user must type 'remove'

How Has This Been Tested?

API 33 emulator

with non-validated account
with validated account

Learning (optional, can help others)

Google 🤷‍♂️ ... happily let copycats into the store, still make us jump through hoops

Checklist

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

display a sample email account

github-actions · 2024-04-23T18:59:25Z

Message to maintainers, this PR contains strings changes.

Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

mikehardy · 2024-04-23T19:10:09Z

As long as the copycat also respects user privacy and we are not guarding intellectual property in the "Anki" name copycats are fine 🤷 - orthogonal issues

AnkiDroid/src/main/java/com/ichi2/anki/MyAccount.kt

* onKeyDown is now incorrect * Syncing used to be done on this screen * use `?.also` * loggedIntoMyAccountView

Required by Google Play > Such web links must be functional (e.g., load without errors) > relevant in scope e.g., > * have a pathway for requesting account deletion prominently displayed on the page > * and easily accessible > The name of the app or developer must be known (that is, it must match the name shown in the Google Play store listing) This change begins this: * A 'remove account' button opens AnkiWeb * A user must log in to AnkiWeb if they did not already do so in 'Shared Decks' * ⚠️ A user must close and reopen the screen * ⚠️ A user must press the 'remove account' button again * A user must enter their password * A user must type 'remove' ⚠️ The name of the app is not provided on this screen Issue 16256

AnkiDroid/src/main/java/com/ichi2/anki/MyAccount.kt

AnkiDroid/src/main/res/values/01-core.xml

Use a WebView as we need to control the 'after login' URL AnkiWeb currently redirects from 'https://ankiweb.net/account/remove-account -> * https://ankiweb.net/account/login then to either: * https://ankiweb.net/account/verify-email * https://ankiweb.net/decks Pressing 'back' on this screen closes it ---- Improvement to flow: ```diff * A 'remove account' button opens AnkiWeb * A user must log in to AnkiWeb if they did not already do so in 'Shared Decks' - * ⚠️ A user must close and reopen the screen - * ⚠️ A user must press the 'remove account' button again * A user must enter their password * A user must type 'remove' ``` Issue 16256

Google Request Issue 16256

david-allison · 2024-04-23T19:34:44Z

Nits picked, Privacy policy added

mikehardy

Everything looks good, pulled it locally: tested all UI elements etc, working ✅
Fantastic, thank you

lukstbit

Ok, for the code changes.

Is there a way to include some information on the deletion page that this account is used by all compatible Anki ecosystem apps including Anki Mobile, Anki Desktop, and AnkiDroid Flashcards?

Ask Damien very nicely to put a mention about the clients currently using the account data(Anki, Anki Mobile and AnkiDroid Flashcards)?

david-allison · 2024-04-24T14:53:20Z

We have full control over the page as it's in a WebView

But we also need this if the user clicks the delete account link from the Play Store, which isn't under our control

mikehardy · 2024-04-25T17:17:43Z

Just trying to push strings through past flakiness... #16267

github-actions · 2024-04-25T19:06:59Z

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

dae · 2024-04-29T04:32:17Z

Ask Damien very nicely to put a mention about the clients currently using the account data(Anki, Anki Mobile and AnkiDroid Flashcards)?

I can do this as a last resort, but I think it's unreasonable for a third-party service to have to do this - have you tried pointing out to them that the service is not under your control? I'm sure Twitter/X's account removal page doesn't list all the third-party clients that access it for example.

snowtimeglass · 2024-04-30T08:14:59Z

As a desirable approach on the client (AnkiDroid) side, I suppose that it would be better to use AnkiWeb logo for the "AnkiWeb account" screen rather than AnkiDroid logo (only), to be less misleading.

In case that an app has a screen for connecting to Twitter/X, it is natural to use Twitter/X logo in the screen, rather than the logo of the app itself (only).

I would think the same is true for the screen for connecting to AnkiWeb.

snowtimeglass · 2024-04-30T08:36:16Z

it would be better to use AnkiWeb logo for the "AnkiWeb account" screen rather than AnkiDroid logo (only), to be less misleading.

That is, for example,

Simply replacing the logo
Displaying the two logos to visualize the independence of the app (AnkiDroid) and the external service (AnkiWeb) from each other.

[Reference]

[image]

(Anyway, the current logo on the screen may be a bit too big.)

david-allison · 2024-04-30T10:24:45Z

As a desirable approach on the client (AnkiDroid) side, I suppose that it would be better to use AnkiWeb logo for the "AnkiWeb account" screen rather than AnkiDroid logo (only), to be less misleading.

In case that an app has a screen for connecting to Twitter/X, it is natural to use Twitter/X logo in the screen, rather than the logo of the app itself (only).

I think the same would be true for the screen for connecting to AnkiWeb.

Could you move these comments to a separate issue? I agree and they should be discussed, but they'll be lost if added to a closed PR

docs(my-account): fix 'logged in' preview

184eacd

display a sample email account

david-allison added the Review High Priority Request for high priority review label Apr 23, 2024

github-actions bot added the Strings label Apr 23, 2024

mikehardy reviewed Apr 23, 2024

View reviewed changes

AnkiDroid/src/main/java/com/ichi2/anki/MyAccount.kt Show resolved Hide resolved

david-allison added the Needs Author Reply Waiting for a reply from the original author label Apr 23, 2024

david-allison force-pushed the remove-account branch from f7ecd8c to a060092 Compare April 23, 2024 19:14

david-allison added 2 commits April 23, 2024 20:14

refactor: MyAccount

3f03043

* onKeyDown is now incorrect * Syncing used to be done on this screen * use `?.also` * loggedIntoMyAccountView

mikehardy reviewed Apr 23, 2024

View reviewed changes

AnkiDroid/src/main/java/com/ichi2/anki/MyAccount.kt Outdated Show resolved Hide resolved

david-allison force-pushed the remove-account branch 2 times, most recently from 0668fe5 to 8f0efa7 Compare April 23, 2024 19:16

mikehardy reviewed Apr 23, 2024

View reviewed changes

AnkiDroid/src/main/res/values/01-core.xml Outdated Show resolved Hide resolved

david-allison force-pushed the remove-account branch from 8f0efa7 to 7cea8b6 Compare April 23, 2024 19:19

feat: open privacy policy on Login/Account screen

43c9da4

Google Request Issue 16256

david-allison removed the Needs Author Reply Waiting for a reply from the original author label Apr 23, 2024

mikehardy approved these changes Apr 23, 2024

View reviewed changes

mikehardy added the Needs Second Approval Has one approval, one more approval to merge label Apr 23, 2024

lukstbit approved these changes Apr 24, 2024

View reviewed changes

lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Apr 24, 2024

mikehardy added Blocked by dependency Currently blocked by some other dependent / related change and removed Blocked by dependency Currently blocked by some other dependent / related change labels Apr 25, 2024

mikehardy merged commit a81a828 into ankidroid:main Apr 25, 2024
5 checks passed

github-actions bot added this to the 2.18 release milestone Apr 25, 2024

github-actions bot removed Review High Priority Request for high priority review Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) labels Apr 25, 2024

david-allison deleted the remove-account branch April 28, 2024 01:02

snowtimeglass mentioned this pull request Apr 30, 2024

[suggestion] Add AnkiWeb logo to 'AnkiWeb account' screen #16300

Closed

david-allison mentioned this pull request May 13, 2024

Explain 'Delete Account' ankidroid/ankidroiddocs#134

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: initial 'Remove account' implementation #16260

feat: initial 'Remove account' implementation #16260

david-allison commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 23, 2024

mikehardy commented Apr 23, 2024

david-allison commented Apr 23, 2024

mikehardy left a comment

lukstbit left a comment

david-allison commented Apr 24, 2024

mikehardy commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

dae commented Apr 29, 2024

snowtimeglass commented Apr 30, 2024 •

edited

Loading

snowtimeglass commented Apr 30, 2024 •

edited

Loading

david-allison commented Apr 30, 2024

feat: initial 'Remove account' implementation #16260

feat: initial 'Remove account' implementation #16260

Conversation

david-allison commented Apr 23, 2024 • edited Loading

Purpose / Description

Fixes

Approach

How Has This Been Tested?

Learning (optional, can help others)

Checklist

github-actions bot commented Apr 23, 2024

mikehardy commented Apr 23, 2024

david-allison commented Apr 23, 2024

mikehardy left a comment

Choose a reason for hiding this comment

lukstbit left a comment

Choose a reason for hiding this comment

david-allison commented Apr 24, 2024

mikehardy commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

dae commented Apr 29, 2024

snowtimeglass commented Apr 30, 2024 • edited Loading

snowtimeglass commented Apr 30, 2024 • edited Loading

david-allison commented Apr 30, 2024

david-allison commented Apr 23, 2024 •

edited

Loading

snowtimeglass commented Apr 30, 2024 •

edited

Loading

snowtimeglass commented Apr 30, 2024 •

edited

Loading