Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC'24] rename pager #16783

Merged
merged 1 commit into from
Jul 26, 2024
Merged

[GSoC'24] rename pager #16783

merged 1 commit into from
Jul 26, 2024

Conversation

SanjaySargam
Copy link
Contributor

Purpose / Description

Renaming these two pager ids so that android-studio should know both are different pager

Fixes

#16529 (comment)

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@SanjaySargam SanjaySargam changed the title rename: pager rename pager Jul 25, 2024
@SanjaySargam SanjaySargam added Needs Review GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors labels Jul 25, 2024
@SanjaySargam SanjaySargam changed the title rename pager [GSoC'24] rename pager Jul 25, 2024
@david-allison david-allison added this pull request to the merge queue Jul 26, 2024
@david-allison david-allison removed this pull request from the merge queue due to a manual request Jul 26, 2024
Renaming these two pager ids so that android-studio should know both are different pager
@david-allison
Copy link
Member

@SanjaySargam We're no longer using 'chore', I've changed this to 'refactor' in the commit message

@david-allison david-allison added this pull request to the merge queue Jul 26, 2024
Merged via the queue into ankidroid:main with commit d76e695 Jul 26, 2024
8 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants