-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : [Bug] The layout of the Axis Picker screen is not displaying correctly in landscape mode #17064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- never do merge commits
- never push commits that are useless like ones that just say "change"
Please rebase this to have only the change you want in a single nice commit with descriptive message
I can't review it otherwise
4956e5f
to
64e11fd
Compare
@mikehardy review comments are done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this one - my UI skills are weak but I think Brayan is our most skilled UI reviewer, so deferring, but it...appears correct to my not-very-well-trained eye
I'll look at it by next week |
Hi @lukstbit ,can u please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in your other PR.
64e11fd
to
e92799d
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose / Description
The layout of the Axis Picker screen is not displaying correctly in landscape mode
Fixes
Approach
How Has This Been Tested?
Physical android device
##Screenshot
Checklist
Please, go through these checks before submitting the PR.