Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : [Bug] The layout of the Axis Picker screen is not displaying correctly in landscape mode #17064

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

Prince-kushwaha
Copy link
Contributor

Purpose / Description

The layout of the Axis Picker screen is not displaying correctly in landscape mode

Fixes

Approach

How Has This Been Tested?

Physical android device

##Screenshot

WhatsApp Image 2024-09-14 at 3 47 58 PM

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • never do merge commits
  • never push commits that are useless like ones that just say "change"

Please rebase this to have only the change you want in a single nice commit with descriptive message

I can't review it otherwise

@mikehardy mikehardy added the Needs Author Reply Waiting for a reply from the original author label Sep 16, 2024
@Prince-kushwaha
Copy link
Contributor Author

@mikehardy review comments are done

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this one - my UI skills are weak but I think Brayan is our most skilled UI reviewer, so deferring, but it...appears correct to my not-very-well-trained eye

@mikehardy mikehardy added UI Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author labels Sep 20, 2024
@BrayanDSO BrayanDSO added the Needs reviewer reply Waiting for a reply from another reviewer label Sep 22, 2024
@BrayanDSO
Copy link
Member

I'll look at it by next week

@Prince-kushwaha
Copy link
Contributor Author

Hi @lukstbit ,can u please review this PR

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in your other PR.

@lukstbit lukstbit added Needs Author Reply Waiting for a reply from the original author and removed Needs reviewer reply Waiting for a reply from another reviewer labels Oct 5, 2024
@Prince-kushwaha
Copy link
Contributor Author

Same comment as in your other PR.

done

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Author Reply Waiting for a reply from the original author Needs Second Approval Has one approval, one more approval to merge labels Oct 5, 2024
@lukstbit lukstbit added this pull request to the merge queue Oct 5, 2024
Merged via the queue into ankidroid:main with commit 3d6ac83 Oct 5, 2024
9 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Oct 5, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: The layout of the Axis Picker screen is not displaying correctly in landscape mode
4 participants