Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]:The Set Due Date dialog box is missing its title #17143

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

gautamsingh2
Copy link
Contributor

@gautamsingh2 gautamsingh2 commented Sep 26, 2024

Purpose / Description

The Set Due Date dialog box is missing its title .

Fixes

##Screenshot
settings-> controls->set due date
WhatsApp Image 2024-09-26 at 4 27 46 PM

settings-> appearance->app bar button-> set due date
WhatsApp Image 2024-09-26 at 4 27 45 PM

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Contributor

Message to maintainers, this PR contains strings changes.

  1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
  2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

@user1823
Copy link
Contributor

Instead of creating a new string, use TR.actionsSetDueDate from the backend.

@criticalAY
Copy link
Contributor

This PR is irrelevant since these a tool string as are visible in dev build only, actual strings are coming from backend only

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should come from the backend.

  • update the xml files to note that this is the reason the strings are hardcoded
  • update the code to set the title using (I believe): TR.actionsSetDueDate().toSentenceCase(this@SetDueDateDialog, R.string.sentence_set_due_date))

@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Sep 27, 2024
@gautamsingh2
Copy link
Contributor Author

review feedback done

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author Strings labels Sep 30, 2024
@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Oct 1, 2024
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Author Reply Waiting for a reply from the original author Needs Second Approval Has one approval, one more approval to merge labels Oct 4, 2024
@lukstbit lukstbit added this pull request to the merge queue Oct 4, 2024
Merged via the queue into ankidroid:main with commit 871ac24 Oct 4, 2024
9 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Oct 4, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: The "Set Due Date" dialog box is missing its title
5 participants