-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]:The Set Due Date dialog box is missing its title #17143
Conversation
Message to maintainers, this PR contains strings changes.
Read more about updating strings on the wiki, |
Instead of creating a new string, use |
This PR is irrelevant since these a tool string as are visible in dev build only, actual strings are coming from backend only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should come from the backend.
- update the xml files to note that this is the reason the strings are hardcoded
- update the code to set the title using (I believe):
TR.actionsSetDueDate().toSentenceCase(this@SetDueDateDialog, R.string.sentence_set_due_date))
c7ba2f7
to
f3e9fe4
Compare
review feedback done |
AnkiDroid/src/main/java/com/ichi2/anki/preferences/ControlsSettingsFragment.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/preferences/CustomButtonsSettingsFragment.kt
Outdated
Show resolved
Hide resolved
f3e9fe4
to
142b950
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Purpose / Description
The Set Due Date dialog box is missing its title .
Fixes
##Screenshot
settings-> controls->set due date
settings-> appearance->app bar button-> set due date
Checklist
Please, go through these checks before submitting the PR.