Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multimedia bottomsheet nav bar color transparency #17165

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

criticalAY
Copy link
Contributor

Purpose / Description

It was pointed out by @david-allison when the bottom sheet code was merged as non blocker, hence I am resolving it now, this PR makes the nav bar color transparent.

How Has This Been Tested?

Google emulator API 35:
image

Learning (optional, can help others)

Resources used: Google M3 docs

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

AnkiDroid/src/main/res/values/theme_dark.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values/theme_black.xml Outdated Show resolved Hide resolved
@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Sep 30, 2024
@criticalAY criticalAY removed the Needs Author Reply Waiting for a reply from the original author label Sep 30, 2024
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukstbit lukstbit added the Needs Second Approval Has one approval, one more approval to merge label Sep 30, 2024
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@david-allison david-allison added this pull request to the merge queue Sep 30, 2024
@david-allison david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Sep 30, 2024
Merged via the queue into ankidroid:main with commit ba7f7df Sep 30, 2024
9 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Sep 30, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants