Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync dialog issue #17739

Closed
wants to merge 1 commit into from

Conversation

Leadernelson
Copy link

@Leadernelson Leadernelson commented Jan 6, 2025

Fixes #17551

Modify buildDeckList in AnkiDroid/src/main/java/com/ichi2/anki/widgets/DeckAdapter.kt to calculate lists outside the lock and swap them after.

  • Calculate the new lists outside the lock.
  • Swap the lists inside the lock.
  • Remove the TODO comment about holding the lock for too long and performing I/O inside it.

For more details, open the Copilot Workspace session.

Fixes #17551

Modify `buildDeckList` in `AnkiDroid/src/main/java/com/ichi2/anki/widgets/DeckAdapter.kt` to calculate lists outside the lock and swap them after.

* Calculate the new lists outside the lock.
* Swap the lists inside the lock.
* Remove the TODO comment about holding the lock for too long and performing I/O inside it.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/ankidroid/Anki-Android/issues/17551?shareId=XXXX-XXXX-XXXX-XXXX).
@Leadernelson Leadernelson deleted the fix-sync-dialog branch January 6, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very long 'Processing' dialog if AutoSync is enabled and AnkiWeb is down. ANR if no notification permissions
1 participant