fix: flag not being set in old reviewer #17750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the flag menu items used their code/order as ID before (that may lead to conflicts, so it isn't a good practice).
After 1a96697 they use proper IDs, but those IDs weren't handled at onOptionsItemSelected
Fixes
How Has This Been Tested?
Issue reproduction steps
Checklist
Please, go through these checks before submitting the PR.