Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flag not being set in old reviewer #17750

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

BrayanDSO
Copy link
Member

For some reason, the flag menu items used their code/order as ID before (that may lead to conflicts, so it isn't a good practice).

After 1a96697 they use proper IDs, but those IDs weren't handled at onOptionsItemSelected

Fixes

How Has This Been Tested?

Issue reproduction steps

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

For some reason, the flag menu items used their order as ID before (that may lead to conflicts, so it isn't a good practice).

After 1a96697 they use proper IDs, but those IDs weren't handled at onOptionsItemSelected
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukstbit lukstbit added the Needs Second Approval Has one approval, one more approval to merge label Jan 7, 2025
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@mikehardy mikehardy added this pull request to the merge queue Jan 7, 2025
Merged via the queue into ankidroid:main with commit 7d11fb7 Jan 7, 2025
12 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jan 7, 2025
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can’t change "Flag" status from App bar button / menu in Reviewer
3 participants