Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve congrats message when no cards due later in day #17756

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

user1823
Copy link
Contributor

@user1823 user1823 commented Jan 7, 2025

Purpose / Description

After #16566, the string studyoptions_congrats_finished is used only when there are no cards due later in the day. The previous wording was "You have finished for now." This might suggest that some cards may be due later in the day (it was indeed supposed to imply that before the above-mentioned PR). The changed text makes the meaning clearer.

Fixes

  • Fixes None

Approach

How does this change address the problem?

How Has This Been Tested?

Not tested

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link

welcome bot commented Jan 7, 2025

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@user1823
Copy link
Contributor Author

user1823 commented Jan 7, 2025

First PR! 🚀

There is something wrong with this bot. This is not my first PR! 😅

@mikehardy
Copy link
Member

@user1823

There is something wrong with this bot. This is not my first PR!

Typical AI slop ;-)

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! But we should work on getting a better congrats screen

@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label Jan 7, 2025
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 7, 2025
@BrayanDSO
Copy link
Member

No added or removed strings. I'm assuming I can merge it without a translations sync

@BrayanDSO BrayanDSO added this pull request to the merge queue Jan 7, 2025
Merged via the queue into ankidroid:main with commit 16a4de8 Jan 7, 2025
12 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 7, 2025
@user1823 user1823 deleted the patch-1 branch January 8, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants