-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve congrats message when no cards due later in day #17756
Conversation
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
Important Maintainers: This PR contains Strings changes
|
There is something wrong with this bot. This is not my first PR! 😅 |
Typical AI slop ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! But we should work on getting a better congrats screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
No added or removed strings. I'm assuming I can merge it without a translations sync |
Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR. Read more about updating strings on the wiki, |
Purpose / Description
After #16566, the string
studyoptions_congrats_finished
is used only when there are no cards due later in the day. The previous wording was "You have finished for now." This might suggest that some cards may be due later in the day (it was indeed supposed to imply that before the above-mentioned PR). The changed text makes the meaning clearer.Fixes
Approach
How does this change address the problem?
How Has This Been Tested?
Not tested
Learning (optional, can help others)
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.