fix(browse): fix regression showing borders

[david-allison]

Fixes

• Fixes Browser: Show borders between adjacent cards #17751

Approach

Use DividerItemDecoration

How Has This Been Tested?

API 34 emulator

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[mikehardy]

let there be dividers

[mikehardy]

Actually - wait - looked at it locally

in light theme, pretty light, could be darker
in plain theme, mmm they look pretty light to me
in dark theme, they are not quite dark enough IMHO
in black theme they are basically invisible

Is there a way to have them be color-of-font but half-saturation or similar? Or maybe just whatever they were before so there's no bikeshedding 😆

Right now they exist but aren't strong enough in most themes IMHO

[david-allison]

Fixed. Great catch

PS: That change was ridiculously complex :/. There were issues as cardBrowserDivider was defined as a color, but provided with a reference

[mikehardy]

I still had an old parallel build on my mobile so I was able to compare it vs this running on an emulator. Looks exactly the same to me now in all 4 themes

[mikehardy]

I'm merging straightaway because fixing a regression with a clean fix that achieves parity doesn't really leave much for anyone else to do, time best spent elsewhere IMHO :)