Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(browser-options): remove superfluous text #17763

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

david-allison
Copy link
Member

"Toggle Showing cards or notes in the browser" wasn't useful to explain cards/notes mode

Added in 937a656 (#12035)

How Has This Been Tested?

Screenshot 2025-01-08 at 01 11 19 Screenshot 2025-01-08 at 01 09 07

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison changed the title improvement(deck-options): remove superfluous text improvement(browser-options): remove superfluous text Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

"Toggle Showing cards or notes in the browser" wasn't
useful to explain cards/notes mode

Added in 937a656
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - was just restating exactly what the UI elements already stated

@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Jan 8, 2025
@lukstbit lukstbit added this pull request to the merge queue Jan 8, 2025
Merged via the queue into ankidroid:main with commit 79e0a55 Jan 8, 2025
9 checks passed
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 8, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants