Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preferences): status bar color #17932

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

BrayanDSO
Copy link
Member

Also make transparent the default color for the status bar in SingleFragmentActivity

Fixes

How Has This Been Tested?

Checked if the status bar follows the toolbar color in the settings screen

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Feb 8, 2025
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related issue in #16953
Setting the status bar as transparent everywhere is going to bring back the issue with the black text in status bar for NoteEditor for example.

Wouldn't simply making the status bar transparent in just PreferencesActivity be enough?

Also make transparent the default color for the status bar in SingleFragmentActivity
@BrayanDSO
Copy link
Member Author

Setting the status bar as transparent everywhere is going to bring back the issue with the black text in status bar for NoteEditor for example.

Fixed there.

Wouldn't simply making the status bar transparent in just PreferencesActivity be enough?

It would, but I prefer having transparent as the default.

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Feb 9, 2025
@lukstbit lukstbit added this pull request to the merge queue Feb 9, 2025
Merged via the queue into ankidroid:main with commit ed1ca6e Feb 9, 2025
9 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 9, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Settings status bar color
3 participants