Abstract TimeManager to create reusable resettable variable#19113
Closed
Arthur-Milchior wants to merge 1 commit intoankidroid:mainfrom
Closed
Abstract TimeManager to create reusable resettable variable#19113Arthur-Milchior wants to merge 1 commit intoankidroid:mainfrom
Arthur-Milchior wants to merge 1 commit intoankidroid:mainfrom
Conversation
Other values than TimeManager may need to be set in test and reset otherwise. In particular it could be useful for ankidroid#18856. I tried to abtsract this class. As the stack always had a single value, I removed it. I don't expect that defining a child class will be useful all the time. But in this case, introducing `time` avoid changing many many files and keep the code more readble.
david-allison
requested changes
Aug 21, 2025
david-allison
added
the
Needs Author Reply
Contributor
|
Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other values than TimeManager may need to be set in test and reset otherwise. In particular it could be useful for #18856.
I tried to abtsract this class. As the stack always had a single value, I removed it.
I don't expect that defining a child class will be useful all the time. But in this case, introducing
timeavoid changing many many files and keep the code more readble.