fix: respect 24h time display preference#19265
Merged
lukstbit merged 1 commit intoankidroid:mainfrom Sep 25, 2025
Merged
Conversation
GSoC 2025: Review Reminder Fixed an issue where the time displayed for ReviewReminders did not respect the OS setting for whether to use 12h or 24h time. Accomplished by simply utilizing a Context.
ericli3690
added
Needs Review
GSoC
david-allison
approved these changes
Sep 25, 2025
david-allison
added
Needs Second Approval
lukstbit
approved these changes
Sep 25, 2025
lukstbit
added
Pending Merge
github-actions
bot
removed
the
Pending Merge
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixed an issue where the time displayed for ReviewReminders did not respect the OS setting for whether to use 12h or 24h time.
Fixes
GSoC 2025: Review Reminders
Approach
Accomplished by simply utilizing a Context.
How Has This Been Tested?
Builds and runs on a physical Samsung S23, API 34. Switching languages, changing the 12h/24h setting works, etc.
Checklist