Fix/template editing undo

[7se7en72025]

Purpose / Description

This PR fixes an issue where editing card templates after deleting a deck would break the undo functionality. When users deleted a deck and then edited a template, they could no longer undo either operation. This happened because template editing operations were not wrapped in undoableOp, so they weren't being tracked in the undo history.

Fixes

• Fixes Editing templates breaks the undo feature #19187

Approach

The fix wraps the saveNoteType operation in undoableOp to ensure template editing changes are properly tracked in the undo history. Specifically:

1. Made saveToDatabase a suspend function - This allows it to use undoableOp which is a suspend function
2. Wrapped saveNoteType in undoableOp - This ensures all template editing operations (adding/deleting templates, updating template content) are tracked in the undo history
3. Removed the col parameter - Since undoableOp provides the Collection context via withCol, the parameter is no longer needed
4. Removed the TODO comment - The comment "TODO: make undoable" has been addressed

The changes ensure that template editing operations are properly integrated with Anki's undo system, matching the behavior of other operations like deck deletion.

How Has This Been Tested?

Manual Testing Steps:

1. Delete a deck (this creates an undo entry)
2. Edit a template of a note type (add/remove templates or modify template content)
3. Save the template changes
4. Attempt to undo - both the template editing and deck deletion should be undoable

Test Configuration:

• Tested on Android emulator and physical device
• Verified that undo history is preserved correctly
• Confirmed that template changes can be undone independently of deck deletion

Expected Behavior:

• After deleting a deck and editing templates, users can undo template editing
• Users can also undo the deck deletion that occurred before template editing
• Undo history is properly maintained for both operations

Learning (optional, can help others)

• The undoableOp function is the standard way to wrap operations that should be undoable in AnkiDroid
• undoableOp internally uses withCol to provide Collection context, so operations don't need to manually pass the Collection
• Schema modifications (like template changes) need to be wrapped in undoableOp to preserve undo history
• The undo system tracks operations at the backend level, so all operations that modify the database should use undoableOp

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner