fix(image-occlusion): support updating a note's deck

[david-allison]

Purpose / Description

From the Reviewer, I could not edit the deck of an image occlusion note

This functionality was not implemented on ImageOcclusion. Only editing the deck of 'add' was supported, and the 'edit deck' functionality of NoteEditorFragment was hidden

In future, we can handle this inImageOcclusion, BUT:

There are 3 cases:

• A user wants to edit a card when studying
• A user wants to edit a selection of cards from the same note [Card Browser - CARDS]
• A user wants to edit a note [Card Browser - NOTES]
  • What does it mean to edit the deck of a note, is a user aware of this?

And a user can remove the cards they are editing (by removing masks).

Since we don't yet have full control over the process of adding an occlusion note, I decided it was a risk to take the time to implement this, and went for a simple fix

Fixes

• Fixes Image Occlusion: cannot edit deck of a card #19605
• Fixes (2.23.0alpha6) Changing the deck in the "Deck" field of the Image Occlusion editor doesn't make the new note to be added to the selected deck #19426

Approach

Beforehand, I refactored the Image Occlusion screen:

• Moving to a discriminated union, to make invalid states non-representable
• Moving to flows, to reduce

Then:

• Enable editing the deck in NoteEditorFragment if in edit mode
• Disable editing the deck in ImageOcclusion if in edit mode

How Has This Been Tested?

Pixel 9 API 35 emulator:

• Add Image Occlusion note by 'share' & change deck from default
  • ✅ Deck is set on note
  • ✅ Current deck is not changed
• Add Image Occlusion note by 'add'
  • ✅ Deck is set on note
  • ✅ Current deck is not changed
• Edit Image Occlusion note in 'Review'
  • ✅ Deck is settable in Note Editor
  • ✅ Deck is not settable in Image Occlusion Editor
• Edit Image Occlusion note in 'Review' - removing current mask
  • ✅ 'No cloze 1 found on card ...'
• Edit Image Occlusion card in 'Card Browser'
  • ✅ Deck is changeable in Note Editor
• Edit Image Occlusion note in 'Card Browser'
  • ⚠️ Known buggy: [BUG]: Card Browser - Toggle Notes -> Changing deck in Note Editor only modifies one card #17415

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[lukstbit]

From the Reviewer, I could not edit the deck of an image occlusion note

Unless I'm missing something this isn't possible on desktop either(we can only modify the masks). If this is the case I don't think we should diverge.

We don't quite follow desktop as we don't allow the user to save without any occlusions set but on desktop it just results in an empty card.

[david-allison]

We supported editing the deck in 2.22, I'd rather avoid the regression

As far as I understand the code, It's the backend rejecting the note with 0 occlusions.

[BrayanDSO]

partial review

[david-allison]

Thanks so much for the patch!!

[mikehardy]

Can't see anything that looks off, let's go