feat: apply Frame style to previewers#19843
Merged
BrayanDSO merged 2 commits intoankidroid:mainfrom Jan 7, 2026
Merged
Conversation
AnkiDroid/src/main/java/com/ichi2/anki/previewer/PreviewerFragment.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/previewer/PreviewerFragment.kt
Outdated
Show resolved
Hide resolved
BrayanDSO
added
the
Needs Author Reply
BrayanDSO
force-pushed
the
feat/frame
branch
from
d78c923 to
81086c6
Compare
BrayanDSO
removed
the
Needs Author Reply
david-allison
approved these changes
Dec 20, 2025
AnkiDroid/src/main/java/com/ichi2/anki/previewer/TemplatePreviewerFragment.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt
Show resolved
Hide resolved
| setNavigationOnClickListener { requireActivity().onBackPressedDispatcher.onBackPressed() } | ||
| } | ||
|
|
||
| if (sharedPrefs().getBoolean("safeDisplay", false)) { |
Member
There was a problem hiding this comment.
Reviewer 2: this removal is intentional - review commit-by-commit
david-allison
added
Needs Second Approval
BrayanDSO
force-pushed
the
feat/frame
branch
from
ae1a991 to
9169d29
Compare
BrayanDSO
force-pushed
the
feat/frame
branch
from
9169d29 to
884d10e
Compare
mikehardy
added
Needs Author Reply
Member
|
can't merge a single one of yours! All ending up as pending, but approved at least. This one just needs a conflict removal |
so the previewing experience is similar to the reviewing experience
the setting is supposed to remove animations. Removing the elevation of the previewers containers should not be necessary, as they are static. Also, they can use the "BOX" frame style now
BrayanDSO
removed
Needs Author Reply
github-actions
bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so the previewing experience is similar to the reviewing experience
How Has This Been Tested?
Emulator 31
Checklist
Please, go through these checks before submitting the PR.