Skip to content

Convert FindAndReplaceDialogFragment to ViewBinding#19940

Merged
david-allison merged 1 commit intoankidroid:mainfrom
lukstbit:chore_findReplaceViewBinding
Dec 28, 2025
Merged

Convert FindAndReplaceDialogFragment to ViewBinding#19940
david-allison merged 1 commit intoankidroid:mainfrom
lukstbit:chore_findReplaceViewBinding

Conversation

@lukstbit
Copy link
Member

Purpose / Description

Changes FindAndReplaceDialogFragment to use ViewBinding before moving to production.

Screenshot_20251227_150742Screenshot_20251227_150613

Screenshot_20251227_150635Screenshot_20251227_150657

Fixes

How Has This Been Tested?

Tested again the behavior of the dialog, ran tests, verified appearance in all themes.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Dec 27, 2025
@david-allison david-allison added this pull request to the merge queue Dec 28, 2025
Merged via the queue into ankidroid:main with commit 69fedde Dec 28, 2025
18 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Dec 28, 2025
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Dec 28, 2025
@lukstbit lukstbit deleted the chore_findReplaceViewBinding branch December 28, 2025 05:18
@david-allison david-allison mentioned this pull request Jan 19, 2026
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments