Enable deck option target selection in study screen by lukstbit · Pull Request #19963 · ankidroid/Anki-Android

lukstbit · 2025-12-29T08:09:32Z

Purpose / Description

Added an implementation for this feature around the current code of DeckOptionsDestination. I'm open for suggestions on UI, I just added a simple dialog:

Normal decks(and with long names) + filtered decks

Notice: the contrast isn't great for filtered deck color and black background.

Fixes

Fixes Let the user choose which deck's options to open in the reviewer #19960

How Has This Been Tested?

Opened a lot of decks options screens, verified other usages of DeckOptionsDestination, ran tests.

Checklist

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

david-allison · 2025-12-29T08:43:39Z

Awesome!

Something feels like it's missing visually, but I don't know what

What happens when a deck in the list is long and truncation occurs? Does :: cause problems here

What if there's a lot of entries in the list?

I'd be tempted to add the card count as a subtitle and see how this looks

Can you colour the filtered deck options the same colour as in the deck picker?

Does cancel need to be there? Back or tapping outside should be sufficient

ZornHadNoChoice · 2025-12-29T09:08:13Z

I might not be seeing clearly, but the dialog title doesn't feel prominent enough. Also, the Material 2 guidelines agree with david-allison.

lukstbit · 2025-12-30T07:52:51Z

I updated the images.

What happens when a deck in the list is long and truncation occurs? Does :: cause problems here

Just wraps around and makes the row bigger. I think this is better than truncating.

What if there's a lot of entries in the list?

At most there could be 3 entries based on the implementation.

I'd be tempted to add the card count as a subtitle and see how this looks

I don't think this is a good idea: it would complicate the implementation and I'm not sure what value offers to the user(besides desktop doesn't show this).

Can you colour the filtered deck options the same colour as in the deck picker?

Should've done this from the start.

Does cancel need to be there? Back or tapping outside should be sufficient

No and I removed it. I added it initially to follow the desktop ui.

I updated the dialog appearance by using MaterialAlertDialogBuilder. It has the same surface/container colors issue but this will be fixed later. The contrast for dynamic color on black theme is not great but I'm tempted to leave it for now and wait for the surface colors to be addressed.

Note on the previous design: I just used the normal dialog. Having the title so long probably feels like a message text and not a title.

AnkiDroid/src/main/java/com/ichi2/anki/pages/DeckOptionsDestination.kt

david-allison

Looks good! A couple questions

Also could do with @NeedsTest

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerViewModel.kt

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerViewModel.kt

david-allison · 2026-01-04T18:32:13Z

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt


        viewModel.destinationFlow.collectIn(lifecycleScope) { destination ->
+            if (destination is DeckOptionsDestination && destination.haMultipleOptions) {
+                if (destination.options.any { it.name == null }) {


Is there any other way to handle a 'bad' deck as a non-representable state

for example: making the option itself null, rather than relying on the implicit assumption of name == null => invalid'.

making the option itself null, rather than relying on the implicit assumption of name == null => invalid'.

I modified the code to filter out the options that have a null deck name.

AnkiDroid/src/main/res/layout/item_deck_option_selection.xml

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt

The implementation is inserted around the current code so other usages outside of the new study screen work as before. See https://github.com/lukstbit/anki/blob/d24d2e33943af2361b5a9880572b30887efcf3ee/qt/aqt/deckoptions.py#L83-L100

lukstbit · 2026-01-21T11:30:36Z

I think I fixed all raised issues.

david-allison

Not sure if the start margin is correct.

I feel the text could do with more weight/size

Does this meet the contrast accessibility check?

I'm an approve, trusting implementer on this

david-allison · 2026-01-29T13:10:49Z

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt

+                        )
+                    startActivity(updatedDestination.toIntent(requireContext()))
+                }
+                return@collectIn


Is there a need for this return?

david-allison · 2026-01-29T13:15:28Z

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerViewModel.kt

+        val card = currentCard.await()
+        val options = getDeckOptionsTargets(deckId, card)
+        val isFiltered = options.first { it.deckId == deckId }.isFiltered
+        val destination = DeckOptionsDestination(deckId, isFiltered, options)


nit: this logic could be inside either: DeckOptionsDestination.create(deckId) or DeckOptionsDestination.from(deckId, options), one doing the isFiltered check, one extracting the logic

This feels like a general utility, rather than a responsibility of the study screen

github-actions · 2026-02-12T13:58:27Z

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

lukstbit added the Needs Review label Dec 29, 2025

lukstbit force-pushed the feat_pickDeckOptionsTarget branch from 354ef23 to 87279d8 Compare December 30, 2025 07:37

BrayanDSO reviewed Jan 3, 2026

View reviewed changes

AnkiDroid/src/main/java/com/ichi2/anki/pages/DeckOptionsDestination.kt Outdated Show resolved Hide resolved

david-allison requested changes Jan 4, 2026

View reviewed changes

david-allison added the Needs Author Reply Waiting for a reply from the original author label Jan 4, 2026

github-actions bot added the Has Conflicts label Jan 7, 2026

david-allison mentioned this pull request Jan 16, 2026

Ask which deck options to open in reviewer #20118

Closed

5 tasks

lukstbit force-pushed the feat_pickDeckOptionsTarget branch from 87279d8 to 3f64421 Compare January 21, 2026 08:57

lukstbit removed Needs Author Reply Waiting for a reply from the original author Has Conflicts labels Jan 21, 2026

lukstbit force-pushed the feat_pickDeckOptionsTarget branch from 3f64421 to df78cbb Compare January 21, 2026 11:26

david-allison self-requested a review January 21, 2026 14:42

david-allison reviewed Jan 29, 2026

View reviewed changes

david-allison added Needs Author Reply Waiting for a reply from the original author Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 29, 2026

david-allison approved these changes Jan 29, 2026

View reviewed changes

david-allison added this to the 2.24 release milestone Jan 29, 2026

github-actions bot added the Stale label Feb 12, 2026

Uh oh!

Conversation

lukstbit commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose / Description

Fixes

How Has This Been Tested?

Checklist

Uh oh!

david-allison commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZornHadNoChoice commented Dec 29, 2025

Uh oh!

lukstbit commented Dec 30, 2025

Uh oh!

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

david-allison Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

lukstbit Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lukstbit commented Jan 21, 2026

Uh oh!

david-allison left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

david-allison Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lukstbit commented Dec 29, 2025 •

edited

Loading

david-allison commented Dec 29, 2025 •

edited

Loading

david-allison left a comment •

edited

Loading