refactor: add CardTemplateEditor.getIntent & introduce CardOrdinal

[david-allison]

Purpose / Description

Creating the CardTemplateEditor was unusual, as it creates an intent, then further modifies it.

I found this unclear when working on

• feat(fields): allow insertion of 'special fields' with preview #20041

From first glance, the NoteId was unset (as it used a hardcoded string constant rather than EDITOR_NOTE_ID

Approach

• Define CardOrdinal, as I didn't want to document one Int parameter on getIntent and ignore the rest
• Introduce CardTemplateEditor.getIntent

How Has This Been Tested?

• Pixel 9 Pro: both with 'Manage Note Types' and with the Note Editor, on a non-1 ord card

Logcat: Built intent for CardTemplateEditor; ntid: 1381831066614; nid: 1767661996450; ord: 1

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[BrayanDSO]

TemplatePreviewerViewModel could use CardOrdinal as well

[david-allison]

Re-requested a review as that added a number more CardOrdinal usages

[BrayanDSO]

Still LGTM. Thanks!

[mikehardy]

good to clarify a confusing concept, I remember when I was first learning about note types and ordinals and it took me quite a while to suss out. Likely reflected (still) in the code. Making everything as explicit as possible can't hurt

I was curious what this looked like for ephemeral items or partially specified items and it seems to make sense, e.g. if you just edit a note type but not on a particular card:

01-09 08:33:41.530 4025 4025 D CardTemplateEditor$Companion: Built intent for CardTemplateEditor; ntid: 1767965588557; nid: null; ord: null

(but everything works as it should)

As I'd expect. Let's go