Skip to content

fix(review-reminders): crash on startup#20164

Merged
david-allison merged 1 commit intoankidroid:mainfrom
david-allison:fix-2-24-a3
Jan 19, 2026
Merged

fix(review-reminders): crash on startup#20164
david-allison merged 1 commit intoankidroid:mainfrom
david-allison:fix-2-24-a3

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Jan 19, 2026

Purpose / Description

A breaking schema change was made to ReviewReminder

  • 2.24alpha1
    • Create a few reminders with various parameters
  • Update to 2.24alpha3
    • Crash on open

This caused MissingFieldException: Field 'onlyNotifyIfNoReviews' is required for type with serial name 'com.ichi2.anki.reviewreminders.ReviewReminder', but it was missing

Fixes

Approach

Provide the default value of false to fix this

How Has This Been Tested?

API 35 phone emulator

  • Trigger the bug via alpha1
  • Open the app on main: crash
  • Apply the patch: app opens as normal

Learning (optional, can help others)

Maybe 5 issues need to be created to better handle this in future... but let's get this fixed first.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

A breaking schema change was made to `ReviewReminder`

* 2.24alpha1
  * Create a few reminders with various parameters
* Update to 2.24alpha3
  * Crash on open

This caused `MissingFieldException: Field 'onlyNotifyIfNoReviews' is required for type with serial name 'com.ichi2.anki.reviewreminders.ReviewReminder', but it was missing`

Provide the default value of `false` to fix this

Fixes 20163
@david-allison david-allison added Review High Priority Request for high priority review Needs Review labels Jan 19, 2026
@david-allison
Copy link
Member Author

@ZornHadNoChoice THANK YOU SO MUCH FOR THIS!!!!

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 19, 2026
Copy link
Member

@ericli3690 ericli3690 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I've mentioned on the issue, this is my fault; just woke up, sorry I couldn't see this sooner. I forgot to consider that some users would already be using the review reminder system, even with it as a developer option.

This change looks good to me as a temporary patch and I'll expedite the permanent solution which I should have implemented a long time ago. Apologies to all of you for this mess.

@david-allison david-allison added this pull request to the merge queue Jan 19, 2026
Merged via the queue into ankidroid:main with commit 02cc69b Jan 19, 2026
19 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Jan 19, 2026
@github-actions github-actions bot removed Review High Priority Request for high priority review Needs Second Approval Has one approval, one more approval to merge labels Jan 19, 2026
@david-allison david-allison deleted the fix-2-24-a3 branch January 19, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants