fix(review-reminders): crash on startup#20164
Merged
david-allison merged 1 commit intoankidroid:mainfrom Jan 19, 2026
Merged
Conversation
A breaking schema change was made to `ReviewReminder` * 2.24alpha1 * Create a few reminders with various parameters * Update to 2.24alpha3 * Crash on open This caused `MissingFieldException: Field 'onlyNotifyIfNoReviews' is required for type with serial name 'com.ichi2.anki.reviewreminders.ReviewReminder', but it was missing` Provide the default value of `false` to fix this Fixes 20163
Member
Author
|
@ZornHadNoChoice THANK YOU SO MUCH FOR THIS!!!! |
lukstbit
approved these changes
Jan 19, 2026
ericli3690
approved these changes
Jan 19, 2026
Member
ericli3690
left a comment
There was a problem hiding this comment.
As I've mentioned on the issue, this is my fault; just woke up, sorry I couldn't see this sooner. I forgot to consider that some users would already be using the review reminder system, even with it as a developer option.
This change looks good to me as a temporary patch and I'll expedite the permanent solution which I should have implemented a long time ago. Apologies to all of you for this mess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
A breaking schema change was made to
ReviewReminderThis caused
MissingFieldException: Field 'onlyNotifyIfNoReviews' is required for type with serial name 'com.ichi2.anki.reviewreminders.ReviewReminder', but it was missingFixes
Field 'onlyNotifyIfNoReviews' is required for type with serial name 'com.ichi2.anki.reviewreminders.ReviewReminder', but it was missing#20163Approach
Provide the default value of
falseto fix thisHow Has This Been Tested?
API 35 phone emulator
alpha1main: crashLearning (optional, can help others)
Maybe 5 issues need to be created to better handle this in future... but let's get this fixed first.
Checklist