Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/re-optimize FSRS if short-term param is weird #3742

Conversation

L-M-Sherlock
Copy link
Contributor

Previous discussion: open-spaced-repetition/fsrs4anki#708 (comment)

Current problem: I don't know how to refresh the progress for the second optimization.

@user1823
Copy link
Contributor

I just realized that there are two issues with this approach:

  • Because PLS depends upon the previous stability and previous difficulty, it is possible that the weird behaviour occurs for some values of S and D but not for others. Here, we are checking for one particular set of S and D values.
  • Here, we are reading the number of relearning steps from the preset. But, what if the user has decreased the number of steps and the older revlogs show the weird behaviour? Such cases will be missed by this approach.

Another issue (easily fixable):
We want to count only the same-day relearning steps. Multiday steps won't cause the weird behaviour.

@L-M-Sherlock
Copy link
Contributor Author

  • Because PLS depends upon the previous stability and previous difficulty, it is possible that the weird behaviour occurs for some values of S and D but not for others. Here, we are checking for one particular set of S and D values.

If the weird behavior doesn't occur for S = 1 and D = 1, it will not occur for S > 1 and D > 1 because S_f / S becomes less.

@dae
Copy link
Member

dae commented Jan 25, 2025

Look ok @L-M-Sherlock?

@L-M-Sherlock
Copy link
Contributor Author

debug

@dae, the progress always flickers once I click Optimize.

@dae dae marked this pull request as ready for review January 25, 2025 23:41
@dae dae merged commit 43e8607 into ankitects:main Jan 25, 2025
1 check passed
@L-M-Sherlock L-M-Sherlock deleted the Fix/re-optimize-FSRS-if-short-term-param-is-weird branch January 26, 2025 02:09
@Expertium
Copy link
Contributor

I'm late, but I have a question - have you guys tested whether it works correctly with "Optimize all"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants