Fix ∷ in tags not being converted to :: when cut #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #3062
The tag editor displays
::as∷to simplify(?) hierarchical tag editing (#1264 (comment))The conversion back to
::is handled when copying, but not when cutting, which this pr aims to rectifyOmitting
setPositionmoves the caret to the endOmitting
dispatchmeans not opening autocomplete or updating it if already open (existing behaviour)Didn't notice any regressions with this, but the editor code in general is very confusing and i might've missed something 👀