feat: add weblink to issue (#446) #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitpokhrel
reviewed
Oct 8, 2022
There was a problem hiding this comment.
Hi @Syd7, thank you for working on this 🎉.
The functionality seems to be working, however some comments needs to be addressed in order for this to get merged.
- Instead of a separate command, I think this should be a subcommand for
link. We can add a subcommand calledremoteso that we can do the following.$ jira issue link remote KEY-123 https://example.com "Example text"
- In current implementation, if you run
jira issue remotelinkit directly calls the Jira API. It would be nice to ask for the required parameters in tui like we do forjira issue link. - Instead of calling it
WebLink, let's useRemoteLinkin the API implementation since the Jira API calls itRemoteLink. We can use the term web link in the help text and doc if that's confusing. - Also, please update the README.
| // NewCmdWeblink is a link command. | ||
| func NewCmdWeblink() *cobra.Command { | ||
| cmd := cobra.Command{ | ||
| Use: "remotelink ISSUE_KEY WEBLINK_URL WEBLINK_TITLE", |
There was a problem hiding this comment.
Suggested change
| Use: "remotelink ISSUE_KEY WEBLINK_URL WEBLINK_TITLE", | |
| Use: "remote ISSUE_KEY WEBLINK_URL WEBLINK_TITLE", |
|
Hi @ankitpokhrel 👋 thanks for the review. I think I addressed the comments that you pointed out. please let me know if I missed anything. |
There was a problem hiding this comment.
Hi @Syd7, I have some minor comments, otherwise this looks good. Great work!
|
Hi again @ankitpokhrel, I resolved the remaining comments let me know how it looks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds the possibility to create a weblink for an issue. #446