Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fxmcpserver/fxmcpservertest/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/ankorstore/yokai/log/logtest"
"github.com/mark3labs/mcp-go/server"
"github.com/stretchr/testify/assert"
"go.opentelemetry.io/otel/propagation"
"go.opentelemetry.io/otel/sdk/trace"
)

Expand All @@ -27,11 +28,13 @@ func TestMCPSSETestServer(t *testing.T) {

tp := trace.NewTracerProvider()

tmp := propagation.NewCompositeTextMapPropagator(propagation.TraceContext{}, propagation.Baggage{})

lb := logtest.NewDefaultTestLogBuffer()
lg, err := log.NewDefaultLoggerFactory().Create(log.WithOutputWriter(lb))
assert.NoError(t, err)

hdl := sse.NewDefaultMCPSSEServerContextHandler(gm, tp, lg)
hdl := sse.NewDefaultMCPSSEServerContextHandler(gm, tp, tmp, lg)

mcpSrv := server.NewMCPServer("test-server", "1.0.0")

Expand Down
7 changes: 7 additions & 0 deletions fxmcpserver/module.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/ankorstore/yokai/log"
"github.com/mark3labs/mcp-go/server"
"github.com/prometheus/client_golang/prometheus"
"go.opentelemetry.io/otel/propagation"
"go.opentelemetry.io/otel/trace"
"go.uber.org/fx"
)
Expand Down Expand Up @@ -135,9 +136,15 @@ type ProvideDefaultMCPSSEContextHandlerParam struct {

// ProvideDefaultMCPSSEServerContextHandler provides the default sse.MCPSSEServerContextHandler instance.
func ProvideDefaultMCPSSEServerContextHandler(p ProvideDefaultMCPSSEContextHandlerParam) *sse.DefaultMCPSSEServerContextHandler {
textMapPropagator := propagation.NewCompositeTextMapPropagator(
propagation.TraceContext{},
propagation.Baggage{},
)

return sse.NewDefaultMCPSSEServerContextHandler(
p.Generator,
p.TracerProvider,
textMapPropagator,
p.Logger,
p.MCPSSEServerContextHooks...,
)
Expand Down
22 changes: 14 additions & 8 deletions fxmcpserver/server/sse/context.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/ankorstore/yokai/trace"
"github.com/mark3labs/mcp-go/server"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/propagation"
ot "go.opentelemetry.io/otel/trace"
)

Expand All @@ -28,24 +29,27 @@ type MCPSSEServerContextHandler interface {

// DefaultMCPSSEServerContextHandler is the default MCPSSEServerContextHandler implementation.
type DefaultMCPSSEServerContextHandler struct {
generator uuid.UuidGenerator
tracerProvider ot.TracerProvider
logger *log.Logger
contextHooks []MCPSSEServerContextHook
generator uuid.UuidGenerator
tracerProvider ot.TracerProvider
textMapPropagator propagation.TextMapPropagator
logger *log.Logger
contextHooks []MCPSSEServerContextHook
}

// NewDefaultMCPSSEServerContextHandler returns a new DefaultMCPSSEServerContextHandler instance.
func NewDefaultMCPSSEServerContextHandler(
generator uuid.UuidGenerator,
tracerProvider ot.TracerProvider,
textMapPropagator propagation.TextMapPropagator,
logger *log.Logger,
contextHooks ...MCPSSEServerContextHook,
) *DefaultMCPSSEServerContextHandler {
return &DefaultMCPSSEServerContextHandler{
generator: generator,
tracerProvider: tracerProvider,
logger: logger,
contextHooks: contextHooks,
generator: generator,
tracerProvider: tracerProvider,
textMapPropagator: textMapPropagator,
logger: logger,
contextHooks: contextHooks,
}
}

Expand All @@ -71,6 +75,8 @@ func (h *DefaultMCPSSEServerContextHandler) Handle() server.SSEContextFunc {
ctx = fsc.WithRequestID(ctx, rID)

// tracer propagation
ctx = h.textMapPropagator.Extract(ctx, propagation.HeaderCarrier(req.Header))

ctx = trace.WithContext(ctx, h.tracerProvider)

ctx, span := trace.CtxTracer(ctx).Start(
Expand Down
9 changes: 7 additions & 2 deletions fxmcpserver/server/sse/context_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"github.com/ankorstore/yokai/log/logtest"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"go.opentelemetry.io/otel/propagation"
"go.opentelemetry.io/otel/sdk/trace"
)

Expand All @@ -36,11 +37,13 @@ func TestDefaultMCPSSEServerContextHandler_Handle(t *testing.T) {

tp := trace.NewTracerProvider()

tmp := propagation.NewCompositeTextMapPropagator(propagation.TraceContext{}, propagation.Baggage{})

lb := logtest.NewDefaultTestLogBuffer()
lg, err := log.NewDefaultLoggerFactory().Create(log.WithOutputWriter(lb))
assert.NoError(t, err)

handler := sse.NewDefaultMCPSSEServerContextHandler(gm, tp, lg)
handler := sse.NewDefaultMCPSSEServerContextHandler(gm, tp, tmp, lg)

req := httptest.NewRequest(http.MethodGet, "/sse", nil)

Expand Down Expand Up @@ -91,13 +94,15 @@ func TestDefaultMCPSSEServerContextHandler_Handle(t *testing.T) {

tp := trace.NewTracerProvider()

tmp := propagation.NewCompositeTextMapPropagator(propagation.TraceContext{}, propagation.Baggage{})

lb := logtest.NewDefaultTestLogBuffer()
lg, err := log.NewDefaultLoggerFactory().Create(log.WithOutputWriter(lb))
assert.NoError(t, err)

hk := hook.NewSimpleMCPSSEServerContextHook()

handler := sse.NewDefaultMCPSSEServerContextHandler(gm, tp, lg, hk)
handler := sse.NewDefaultMCPSSEServerContextHandler(gm, tp, tmp, lg, hk)

req := httptest.NewRequest(http.MethodGet, "/sse?sessionId=test-session-id", nil)
req.Header.Set("X-Request-Id", "test-request-id")
Expand Down
Loading