Skip to content

fix(fxgrpcserver): Fix resolution collision by using full import path in type IDs #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

fix(fxgrpcserver): Fix resolution collision by using full import path in type IDs #367

merged 1 commit into from
Sep 2, 2025

Conversation

damnedest
Copy link
Contributor

damnedest
damnedest commented Sep 2, 2025
View reviewed changes
fxgrpcserver/reflect_test.go
"testing"

"github.com/ankorstore/yokai/fxhealthcheck"
"github.com/ankorstore/yokai/fxgrpcserver"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong dependency

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👌

@ekkinox ekkinox merged commit 2cdca0b into ankorstore:main Sep 2, 2025
2 checks passed
@github-actions github-actions bot mentioned this pull request Sep 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekkinox ekkinox ekkinox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@damnedest @ekkinox