Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-633] My Account: Address Book: Main View (#2857) #2

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

ankurvr
Copy link
Owner

@ankurvr ankurvr commented Nov 26, 2020

Sync with parent repo

* Stub out address card functionality based on new mocks

* - Address some missed AC and hide dead links
- Cover changes in tests

* Update snaps and cleanup

* - Sort addresses so default comes first
- Add full page loading indicator on cold cache render
- Add phone number
- Add full country name display

* Use country data from backend until DisplayNames is more widely supported

Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
@ankurvr ankurvr merged commit b21de33 into ankurvr:develop Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants