Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup #371

Merged
merged 27 commits into from
Feb 22, 2023
Merged

Code Cleanup #371

merged 27 commits into from
Feb 22, 2023

Conversation

pseusys
Copy link
Collaborator

@pseusys pseusys commented Feb 17, 2023

In this pull request I revisited all the project code, and:

  • Updated dependencies versions.
  • Restructured files, separated different-purpose and merged same-purpose functions.
  • Added a bunch of new managers to cover external resources (environment, GitHub communication and localization).
  • Provided all the functions with clear names, params and type hints.
  • Added unused coroutines cancellation.
  • Created a codestyle checks.
  • Collected all generated files into assets folder (and docker volume).
  • Removed all NodeJS artifacts.
  • Changed .env files with Makefile integration.

Action runs less than a minute locally.
Image size is .

@pseusys pseusys added the enhancement New feature or request label Feb 17, 2023
@pseusys pseusys self-assigned this Feb 17, 2023
Copy link
Collaborator

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have #377 first before this PR is merged.

@aravindvnair99 aravindvnair99 marked this pull request as draft February 21, 2023 19:51
@pseusys pseusys marked this pull request as ready for review February 21, 2023 19:58
Copy link
Owner

@anmol098 anmol098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm; 🙂

@pseusys pseusys merged commit b4ae785 into master Feb 22, 2023
@pseusys pseusys deleted the feat/code_cleanup branch February 22, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants