copy_files: error out if no files found (ocaml#10649)

* copy_files: error out if no files found

Signed-off-by: Javier Chávarri <javier.chavarri@gmail.com>

doc/changes/10649.md

@@ -0,0 +1 @@
+- Error out if no files are found when using `copy_files`. (#10649, @jchavarri)

src/dune_rules/simple_rules.ml

@@ -227,6 +227,8 @@ let copy_files sctx ~dir ~expander ~src_dir (def : Copy_files.t) =
     in
     Build_system.eval_pred (File_selector.of_glob ~dir glob)
   in
+  if def.syntax_version >= (3, 17) && Filename_set.is_empty files
+  then User_error.raise ~loc [ Pp.textf "Does not match any files" ];
   (* CR-someday amokhov: We currently traverse the set [files] twice: first, to
      add the corresponding rules, and then to convert the files to [targets]. To
      do only one traversal we need [Memo.parallel_map_set]. *)

test/blackbox-tests/test-cases/copy_files/test7.t

@@ -0,0 +1,25 @@
+Show that copy_files errors out if no files are found
+
+  $ mkdir -p target foo
+  $ cat >dune-project <<EOF
+  > (lang dune 3.17)
+  > EOF
+  $ cat >target/dune <<EOF
+  > (copy_files
+  >  (files ../foo/*.txt))
+  > EOF
+
+  $ dune build
+  File "target/dune", line 2, characters 8-20:
+  2 |  (files ../foo/*.txt))
+              ^^^^^^^^^^^^
+  Error: Does not match any files
+  [1]
+
+It doesn't error out in older dune lang versions
+
+  $ cat >dune-project <<EOF
+  > (lang dune 3.16)
+  > EOF
+
+  $ dune build