lwt,eio: remove Client.socket #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
makes sense imo as it was passed from the outside anyway so presumably the caller has access to it and can manage it itself. |
anmonteiro
added a commit
that referenced
this pull request
Apr 27, 2024
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Jun 4, 2024
CHANGES: - gluten-lwt,gluten-eio: remove `Client.socket` ([anmonteiro/gluten#75](anmonteiro/gluten#75)) - gluten-eio: don't require `Eio_unix.stream_socket_ty`, allowing the use of mock sockets ([anmonteiro/gluten#74](anmonteiro/gluten#74))
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: - gluten-lwt,gluten-eio: remove `Client.socket` ([anmonteiro/gluten#75](anmonteiro/gluten#75)) - gluten-eio: don't require `Eio_unix.stream_socket_ty`, allowing the use of mock sockets ([anmonteiro/gluten#74](anmonteiro/gluten#74))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggested by @wokalski