No way to send data with ping and pong #36
Comments
aantron
added a commit
to aantron/dream
that referenced
this issue
Nov 29, 2021
It's not possible to send them at the moment, due to anmonteiro/httpun-ws#36 However, this change should be made now to future-proof the Dream API.
6 tasks
|
fixed in #54 |
aantron
added a commit
to aantron/dream
that referenced
this issue
Nov 10, 2023
Since anmonteiro/httpun-ws#36 was fixed recently, websocket/af supports sending ping and pong payloads, as required by the WebSocket spec. This commit has dream-httpaf using that support. See also #181.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The RFC allows ping and pong frames to have payloads (up to 125 bytes), and requires that a pong for a ping contain the same payload as the ping. However, the current websocket/af API does not allow sending payloads with ping and pong frames:
https://github.com/anmonteiro/websocketaf/blob/248a2cb0dcffa51996c3ad7643577dce75d67454/lib/websocketaf.mli#L151-L152
I actually don't know if ping/pong payloads are used in practice.
The text was updated successfully, but these errors were encountered: