Websocketaf.Client_connection.input_handlers and Server_connection.input_handlers not equal #39
Comments
6 tasks
aantron
changed the title
aantron
added a commit
to aantron/dream
that referenced
this issue
Feb 8, 2022
|
fixed in #47 |
aantron
added a commit
to aantron/hyper
that referenced
this issue
Nov 10, 2023
Since anmonteiro/httpun-ws#39, the equality of the server and client connection handler types has been exposed. Can now use Dream's connection handlers directly, without an Obj.magic cast. See also aantron/dream#181.
aantron
added a commit
to aantron/dream
that referenced
this issue
Nov 10, 2023
Since anmonteiro/httpun-ws#39, an Obj.magic cast from the server's WebSocket handlers to the client's is not longer necessary. See also #181.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The type checker does not admit their equality, even though they are structurally identical:
https://github.com/anmonteiro/websocketaf/blob/248a2cb0dcffa51996c3ad7643577dce75d67454/lib/websocketaf.mli#L188-L190
https://github.com/anmonteiro/websocketaf/blob/248a2cb0dcffa51996c3ad7643577dce75d67454/lib/websocketaf.mli#L229-L231
I think the type either needs to be defined in one place, or there needs to be an
= Client_connection.input_handlersatServer_connection.input_handlers. Or is this lack of equality deliberate?The text was updated successfully, but these errors were encountered: