Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Use cljs.core for cli arguments in cljs.js #237

Merged
merged 2 commits into from
Aug 22, 2017
Merged

Use cljs.core for cli arguments in cljs.js #237

merged 2 commits into from
Aug 22, 2017

Conversation

arichiardi
Copy link
Collaborator

No description provided.

@arichiardi
Copy link
Collaborator Author

arichiardi commented Aug 22, 2017 •
edited
Loading

I have patched this, but I still cannot see the arguments there.

Scratch that, they are there as vectors.

@arichiardi arichiardi mentioned this pull request Aug 22, 2017
Merged
@arichiardi arichiardi force-pushed the fix-cljs-js-cli-args branch from 23ede4b to 9fdbd6e Compare August 22, 2017 19:12
@arichiardi
Copy link
Collaborator Author

Ok so tests from boot test are different, probably need to skip testing the args for those.

@arichiardi arichiardi force-pushed the fix-cljs-js-cli-args branch from 9fdbd6e to fa9734a Compare August 22, 2017 20:46
@arichiardi arichiardi force-pushed the fix-cljs-js-cli-args branch from fa9734a to 6b96ff2 Compare August 22, 2017 22:02
@anmonteiro
Copy link
Owner

Thanks!

@anmonteiro anmonteiro merged commit 63564c1 into anmonteiro:master Aug 22, 2017
anmonteiro added a commit that referenced this pull request Aug 22, 2017
@anmonteiro
Add changelog for #237
8b638b7
@arichiardi arichiardi mentioned this pull request Aug 24, 2017
Merged
This was referenced Aug 27, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arichiardi @anmonteiro