Bump Google Closure Compiler Js to 20180204.0.0

[arichiardi]

https://github.com/google/closure-compiler-js/releases/tag/20180204.0.0

[arichiardi]

Oh, this fails a test:

 
ERROR in (test-npm-deps) (TypeError:NaN:NaN)
Uncaught exception, not in assertion.
expected: nil
  actual: #object[TypeError TypeError: Cannot read property 'replace' of null]
npm WARN lumo No repository field.
npm WARN lumo No license field.

[arichiardi]

The second commit adds stack traces printing for debugging what is going on in the tests, which is:

TypeError: Cannot read property 'replace' of null
    at Object.clojure.string.replace (<embedded>:2079:72)
    at evalmachine.<anonymous>:2908:31
    at <embedded>:1079:205
    at cljs.core.LazySeq.fn (<embedded>:1079:210)
    at cljs.core.LazySeq.sval (<embedded>:794:151)
    at cljs.core.LazySeq.cljs$core$ISeqable$_seq$arity$1 (<embedded>:800:255)
    at Object.cljs.core.seq (<embedded>:506:172)
    at Function.cljs.core.seq_reduce.cljs$core$IFn$_invoke$arity$3 (<embedded>:660:84)
    at cljs.core.LazySeq.cljs$core$IReduce$_reduce$arity$3 (<embedded>:799:250)
    at Function.cljs.core.reduce.cljs$core$IFn$_invoke$arity$3 (<embedded>:667:181)
    at Function.cljs.core.into.cljs$core$IFn$_invoke$arity$2 (<embedded>:1129:255)
    at Object.lumo$closure$get_closure_sources [as get_closure_sources] (evalmachine.<anonymous>:2906:23)
    at Object.lumo$closure$convert_js_modules [as convert_js_modules] (evalmachine.<anonymous>:2958:147)
    at Object.lumo$closure$process_js_modules [as process_js_modules] (evalmachine.<anonymous>:4222:35)
    at Object.lumo$closure$handle_js_modules [as handle_js_modules] (evalmachine.<anonymous>:4343:29)
    at Function.lumo.closure.build.cljs$core$IFn$_invoke$arity$3 (evalmachine.<anonymous>:4514:33)
    at Function.lumo.build.api.build.cljs$core$IFn$_invoke$arity$3 (evalmachine.<anonymous>:594:31)
    at lumo$build$api$build (evalmachine.<anonymous>:514:29)
    at lumo.build_api_tests.test_npm_deps.cljs$lang$test (evalmachine.<anonymous>:378:22)
    at evalmachine.<anonymous>:439:83
    at Object.cljs$test$run_block [as run_block] (evalmachine.<anonymous>:378:82)
    at cljs$test$test_var (evalmachine.<anonymous>:476:18)
    at lumo$test_runner$run_all_tests (evalmachine.<anonymous>:3:27)
    at evalmachine.<anonymous>:35:32
    at ContextifyScript.Script.runInThisContext (vm.js:50:33)
    at Object.runInThisContext (vm.js:152:38)
    at Object._t [as eval] ([eval]:1:29569)
    at Object.lumo.repl.caching_node_eval [as _STAR_eval_fn_STAR_] (<embedded>:6481:68)
    at <embedded>:5837:273
    at E (<embedded>:5838:269)
    at <embedded>:5831:207
    at <embedded>:5729:190
    at Object.cljs.js.load_macros (<embedded>:5702:199)
    at <embedded>:5723:433
    at Object.cljs.js.load_macros (<embedded>:5702:199)
    at <embedded>:5721:316
    at <embedded>:5734:218
    at Function.cljs.js.load_deps.cljs$core$IFn$_invoke$arity$7 (<embedded>:5678:474)
    at <embedded>:5675:570
    at <embedded>:5661:318
    at Object.lumo.repl.run_sync_BANG_ [as run_async_BANG_] (<embedded>:6454:108)
    at Object.cljs.js.process_deps (<embedded>:5637:185)
    at Object.cljs.js.process_libs_deps (<embedded>:5640:60)
    at <embedded>:5658:474
    at Object.lumo.repl.run_sync_BANG_ [as run_async_BANG_] (<embedded>:6454:108)
    at Object.cljs.js.process_deps (<embedded>:5637:185)
    at Object.cljs.js.process_macros_deps (<embedded>:5638:62)
    at <embedded>:5658:198
    at lumo.repl.load (<embedded>:6475:1)
    at Function.cljs.js.require.cljs$core$IFn$_invoke$arity$5 (<embedded>:5664:77)
    at Function.cljs.js.load_deps.cljs$core$IFn$_invoke$arity$7 (<embedded>:5675:119)
    at <embedded>:5675:570
    at <embedded>:5661:318
    at Object.lumo.repl.run_sync_BANG_ [as run_async_BANG_] (<embedded>:6454:108)
    at Object.cljs.js.process_deps (<embedded>:5637:185)
    at Object.cljs.js.process_libs_deps (<embedded>:5640:60)
    at <embedded>:5658:474
    at Object.lumo.repl.run_sync_BANG_ [as run_async_BANG_] (<embedded>:6454:108)
    at Object.cljs.js.process_deps (<embedded>:5637:185)
    at Object.cljs.js.process_macros_deps (<embedded>:5638:62)
    at <embedded>:5658:198
    at Object.lumo.repl.load_bundled (<embedded>:6456:141)
    at Object.lumo.repl.load_and_cb_BANG_ (<embedded>:6469:71)
    at Object.lumo.repl.load_other (<embedded>:6471:234)

[arichiardi]

It seems that this Deraen commit would solve the problem in the tests. However, after a quick glance at the implementation I have not found a way to achieve the same thing in lumo...there is a lot of interaction with the Java implementation that is probably a bit too much for a GCC newbie to grasp and convert to the JS compiler.

Advice is welcome!

[arichiardi]

Superseded by #379.