close descriptor when failed to open connection #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardoRFS
commented
May 24, 2021
| @@ -166,14 +166,19 @@ let make_impl ~config ~conn_info fd = | |||
| let open Lwt_result.Syntax in | |||
| let* () = connect ~config ~conn_info fd in | |||
There was a problem hiding this comment.
TLDR: If this line failed, that would lead to leak of descriptor
|
Tests are blocked by #95 which will fix them. |
anmonteiro
force-pushed
the
fix-infinite-connections
branch
from
b1e0a8c to
afeacad
Compare
|
Thanks! |
anmonteiro
added a commit
that referenced
this pull request
May 28, 2021
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Sep 6, 2024
CHANGES: - Improve certificate checking and authentication ([anmonteiro/piaf#93](anmonteiro/piaf#93)) - [@Firgeis](https://github.com/Firgeis) - Check certificate SAN IP address when appropriate ([anmonteiro/piaf#96](anmonteiro/piaf#96)) - [@Firgeis](https://github.com/Firgeis) - Close the file descriptor when failing to open a connection ([anmonteiro/piaf#97](anmonteiro/piaf#97)) - [@EduardoRFS](https://github.com/EduardoRFS) - Yield to other threads when reading a message body. This improves fairness for large message bodies ([anmonteiro/piaf#100](anmonteiro/piaf#100)) - Add error handling to `Response.of_file` ([anmonteiro/piaf#103](anmonteiro/piaf#103)) - Add `Client.send` which sends a `Request.t` ([anmonteiro/piaf#110](anmonteiro/piaf#110)) - openssl: set the client verify callback ([anmonteiro/piaf#112](anmonteiro/piaf#112)) - Piaf.Response: add `or_internal_error` ([anmonteiro/piaf#120](anmonteiro/piaf#120)) - Piaf.Response: Add `Body.sendfile` and `Response.sendfile` ([anmonteiro/piaf#124](anmonteiro/piaf#124)) - Piaf.Config: Add `config.flush_headers_immediately` ([anmonteiro/piaf#125](anmonteiro/piaf#125)) - Piaf.Server: Add `config.shutdown_timeout` to wait before shutting down the Piaf server ([anmonteiro/piaf#174](anmonteiro/piaf#174)) - Websocket support ([anmonteiro/piaf#139](anmonteiro/piaf#139)) - Multicore support ([anmonteiro/piaf#151](anmonteiro/piaf#151)) - Allow binding to UNIX domain socket ([anmonteiro/piaf#161](anmonteiro/piaf#161)) - Don't send invalid HTTP/2 headers ([anmonteiro/piaf#197](anmonteiro/piaf#197))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the connection failed to start the file descriptor is still open, which blows up lwt when using the select engine as soon as it hits 1024 FDs opens.
Example