Merge pull request #10 from ymkjp/master

Improved usability
announce · Jan 8, 2019 · 8db8657 · 8db8657
2 parents 76f0dd4 + 70d8a62
commit 8db8657
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 21 deletions.
diff --git a/README.md b/README.md
@@ -2,6 +2,11 @@
 
 [![Build Status](https://travis-ci.org/announce/icac.svg?branch=master)](https://travis-ci.org/announce/icac)
 
+## Installation
+
+1. Go to [**iCAC**](https://chrome.google.com/webstore/detail/icac/plbhlfecmbmkphfgcpoijlidjapddidj?utm_source=github)
+2. Install the Chrome Extension
+
 ## Prerequisite
 
 * Docker
@@ -20,15 +25,13 @@ Run the command below:
 For the release:
 
 ```bash
-export FIREBASE_API_KEY="__YOURS_HERE__"
 ./icac release
 ```
 
 Then you will get the crx zipfile in `./var`.
 
 ## Project Links
 
-* Task tracker: [trello](https://trello.com/c/WGVCIKVj/32-app-implementation)
 * Upstream work: [trunk](https://github.com/announce/icac/compare/master...ymkjp:master)
 * Demo app: [crx](https://chrome.google.com/webstore/detail/icac/plbhlfecmbmkphfgcpoijlidjapddidj?utm_source=github)
 * Release: [Chrome Developer Dashboard](https://chrome.google.com/webstore/developer/dashboard)

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "icac",
-  "version": "3.1.0",
+  "version": "3.2.0",
   "description": "[![Build Status](https://travis-ci.org/announce/icac.svg?branch=master)](https://travis-ci.org/announce/icac)",
   "scripts": {
     "test": "npm-run-all clean lint bundle",
@@ -15,13 +15,13 @@
     "image:icon:48": "npm run im -- convert -size 48x48 -background '#0052CC' -fill white -gravity center label:iCAC /app/icon_48.png",
     "image:icon:128": "npm run im -- convert -size 128x128 -background '#0052CC' -fill white -gravity center label:iCAC /app/icon_128.png",
     "watch": "npm-run-all --parallel watch:**",
-    "watch:crx:js": "onchange  --delay 100 '*.json' 'src/**/*.*js' 'script/**/*.js' -- npm-run-all lint:js bundle:crx:js bundle:crx:ejs notify",
+    "watch:crx:js": "onchange  --delay 100 '*.json' 'src/**/*.*js' 'script/**/*.js' -- npm-run-all lint:js bundle:crx:js notify",
     "watch:crx:manifest": "onchange  --delay 1000 'src/crx/manifest.json' -- npm-run-all lint:js bundle:crx:manifest notify",
-    "watch:crx:assets": "onchange  --delay 1000 'src/**/*.{html,css,json}' 'src/**/image' -- npm-run-all lint:css bundle:crx:assets notify",
-    "watch:config": "onchange  --delay 1000 'config/**/*.{js,json}' -- npm-run-all lint:css bundle:crx:assets notify",
+    "watch:crx:assets": "onchange  --delay 1000 'src/**/*.{html,css,json}' 'src/**/image' -- npm-run-all bundle:crx:assets notify",
+    "watch:config": "onchange  --delay 1000 'config/**/*.{js,json}' -- npm-run-all bundle:crx:assets notify",
     "watch:shell": "onchange  --delay 1000 'script/**/*.*sh' -- npm-run-all bundle:crx:secret notify",
     "watch:md": "onchange  --delay 1000 '*.md' -- npm-run-all lint:md notify",
-    "build": "npm-run-all clean image bundle compress",
+    "build": "npm-run-all test image bundle compress",
     "notify": "./script/notify.bash $?",
     "bundle": "npm-run-all bundle:** notify",
     "bundle:script": "babel script -d dist/script",

diff --git a/src/crx/app.js b/src/crx/app.js
@@ -1,16 +1,6 @@
 // @flow
 'use strict'
 
-export const FORM_TYPES: Object = {
-  'satisfactionFeedback': 'SatisfactionFeedbackForm',
-  'translationRequest': 'TranslationRequestForm'
-}
-
-export const MEEPLE: Object = {
-  mogawa: chrome.extension.getURL('image/Meeples-Vania.png'),
-  ahirama: chrome.extension.getURL('image/Meeples-Angie.png')
-}
-
 export const scriptName = 'github.com/announce/icac'
 
 const CAC_DOMAIN = 'confluence.atlassian.com'

diff --git a/src/crx/background.js b/src/crx/background.js
@@ -1,5 +1,4 @@
 'use strict'
-// const _ = require('lodash')
 const app = require('./app')
 
 /**
@@ -37,7 +36,7 @@ const main = (w, chrome) => {
   chrome.runtime.onInstalled.addListener(() => {
     console.log('chrome.runtime.onInstalled:', app.scriptName)
     chrome.contextMenus.create({
-      title: 'Toggle the language switcher',
+      title: '[iCAC] Toggle the language switch',
       contexts: ['page'],
       id: app.scriptName
     })

diff --git a/src/crx/manifest.json b/src/crx/manifest.json
@@ -1,14 +1,13 @@
 {
   "name": "iCAC",
   "version": "",
-  "description": "A Chrome Extension for CAC i18n.",
+  "description": "A Chrome Extension for CAC i18n",
   "icons": {
     "16": "image/icon_16.png",
     "48": "image/icon_48.png",
     "128": "image/icon_128.png"
   },
   "permissions": [
-    "https://*.confluence.atlassian.com/*",
     "contextMenus",
     "tabs",
     "activeTab"