Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts with cypress #1508

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix: ts with cypress #1508

merged 1 commit into from
Jan 7, 2025

Conversation

rmonnier9
Copy link
Contributor

@rmonnier9 rmonnier9 commented Jan 7, 2025

  • Amélioration technique.
  • Détails :
    • C'est le fruit d'une longue investigation : Jest et Cypress utilisent les mêmes types ce qui générait des conflits de types
    • La solution adoptée jusqu'ici était d'ignorer tout le dossier Cypress, ce qui empêchait d'avoir l'assistance de typescript dans le dossier Cypress
    • Solution :
    1. En déplaçant le fichier de config de Cypress, on évite d'importer la lib ailleurs que depuis le dossier "cypress".
    2. Un tsconfig.json spécifique au dossier cypress a été créé.
    3. Les types "jest" et "cypress" ont été précisé dans les deux tsconfig.json pour clarifier les conflits.

Closes #1509

@rmonnier9 rmonnier9 requested a review from XavierJp as a code owner January 7, 2025 12:31
@rmonnier9 rmonnier9 force-pushed the fix-ts-cypress branch 7 times, most recently from 7f2f973 to 2e69699 Compare January 7, 2025 13:39
@rmonnier9 rmonnier9 merged commit 631a5f7 into main Jan 7, 2025
8 checks passed
@rmonnier9 rmonnier9 deleted the fix-ts-cypress branch January 7, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix types with Cypress
2 participants