Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] remove all dynamic allocations #126

Open
anokta opened this issue Jan 4, 2024 · 0 comments
Open

[internal] remove all dynamic allocations #126

anokta opened this issue Jan 4, 2024 · 0 comments
Assignees
@anokta
Labels
cleanup refactor things
Milestone
optimizations

Comments

@anokta
Copy link
Owner

anokta commented Jan 4, 2024

The remaining misused noexcept use is caused by dynamic memory allocations in the internal API.
These all should ideally be replaced by a memory pool in the stack, so keeping bugprone-exception-escape issues in the code intentionally as a reminder to clean this up.

Also see #58 and #60
@anokta anokta added cleanup refactor things stretchfeature p4 things labels Jan 4, 2024
@anokta anokta added this to the optimizations milestone Jan 4, 2024
@anokta anokta self-assigned this Jan 4, 2024
@anokta anokta mentioned this issue Jan 4, 2024
Closed
@anokta anokta removed the stretchfeature p4 things label Sep 25, 2024
anokta added a commit that referenced this issue Oct 18, 2024
@anokta
make musician own all resources
b0babe6 
this is the first step to convert them into pools for #126
anokta added a commit that referenced this issue Oct 18, 2024
@anokta
make musician own all resources
ef208c7 
this is the first step to convert them into pools for #126
anokta added a commit that referenced this issue Nov 25, 2024
@anokta
add a basic memory pool
c859f72 
to be used for instruments etc #126
anokta added a commit that referenced this issue Nov 28, 2024
@anokta
start using memory pool for instruments and performers
213f1f8 
wip #126
anokta added a commit that referenced this issue Nov 28, 2024
@anokta
start using memory pool for instruments and performers
2ed965b 
wip #126
anokta added a commit that referenced this issue Nov 28, 2024
@anokta
use memory pool for performer tasks
f977c39 
#126
anokta added a commit that referenced this issue Dec 1, 2024
@anokta
simplify back note event callbacks
1076663 
the same will go for task events once commands are in -- #126
anokta added a commit that referenced this issue Jan 14, 2025
@anokta
remove memory pool use
9e66ea1 
might add back later after introducing custom allocators
#126
anokta added a commit that referenced this issue Jan 14, 2025
@anokta
remove memory pool use
74a08ac 
might add back later after introducing custom allocators
#126
@anokta anokta mentioned this issue Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anokta anokta

Labels
cleanup refactor things
Projects
None yet
Milestone
optimizations
Development

No branches or pull requests
1 participant
@anokta