Standard library traits #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
force-pushed
the
stdlib-traits
branch
from
f776f7f to
8d6e0d7
Compare
lukaszcz
requested review from
paulcadman and
janmasrovira
and removed request for
paulcadman
lukaszcz
added a commit
to anoma/juvix
that referenced
this pull request
Oct 9, 2023
* Adapts to anoma/juvix-stdlib#86 * Adds a pass in `toEvalTransformations` to automatically inline all record projection functions, regardless of the optimization level. This is necessary to ensure that arithmetic operations and comparisons on `Nat` or `Int` are always represented directly with the corresponding built-in Core functions. This is generally highly desirable and required for the Geb target. * Adds the `inline: always` pragma which indicates that a function should always be inlined during the mandatory inlining phase, regardless of optimization level.
This was referenced Oct 12, 2023
lukaszcz
added a commit
to anoma/juvix
that referenced
this pull request
Oct 12, 2023
* Introduces the `inline: case` pragma which causes an identifier to be inlined if it is matched on. This is necessary to support GEB without compromising optimization for other targets. * Adapts to the new commits in anoma/juvix-stdlib#86
janmasrovira
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrdandEq.OrdtoEqinStdlib.Trait.Ord.Eq.NaturalandIntegral.Nat,Int) need to be imported separately or prefixed withNat,Int.quickchecklibrary needs to be updated for tests to work.